Sidekiq: Rack latest version 2.1.0 seems to breaking the Web console

[kapso]

Ruby version: 2.6.5
Sidekiq: 6.0.4

This is on Heroku, if it helps.

2020-01-10T22:28:07.443550+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] NoMethodError (undefined method `transform_keys' for #<ActionDispatch::Request::Session:0x49c28 not yet loaded>):
2020-01-10T22:28:07.443552+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3]
2020-01-10T22:28:07.443555+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/session/abstract/id.rb:212:in `stringify_keys'
2020-01-10T22:28:07.443557+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/session/abstract/id.rb:148:in `update'
2020-01-10T22:28:07.443559+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/session/abstract/id.rb:317:in `prepare_session'
2020-01-10T22:28:07.443565+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/session/abstract/id.rb:276:in `context'
2020-01-10T22:28:07.443567+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/session/abstract/id.rb:271:in `call'
2020-01-10T22:28:07.443569+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/urlmap.rb:77:in `block in call'
2020-01-10T22:28:07.443571+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/urlmap.rb:61:in `each'
2020-01-10T22:28:07.443574+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/urlmap.rb:61:in `call'
2020-01-10T22:28:07.443576+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] rack (2.1.0) lib/rack/builder.rb:176:in `call'
2020-01-10T22:28:07.443578+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] sidekiq (6.0.4) lib/sidekiq/web.rb:104:in `call'
2020-01-10T22:28:07.443581+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] sidekiq (6.0.4) lib/sidekiq/web.rb:109:in `call'
2020-01-10T22:28:07.443583+00:00 app[web.1]: [4e608183-32f9-426d-8610-d796208f64f3] actionpack (6.0.2.1) lib/action_dispatch/routing/mapper.rb:19:in `block in <class:Constraints>'

Thanks.

[mperham]

Looks like a problem between Rails (your session provider) and Rack. Look for open issues there.

[charlesemarsh]

I'm seeing the same issue now...

[mperham]

There are a lot of changes going on in Rack right now due to numerous bugs in the 2.1 release; please check here and open an issue if you continue to have problems.

https://github.com/rack/rack/commits/master

[wflanagan]

I'm running Rack v2.0.8 and having the same issue. I have other admin sections, and they do not have the same problems., FYI.

Dropping to Rack v2.0.7 did resolve the issue though.

[kapso]

For me, Rack v2.0.8 fixed the issue.

[AnotherJoSmith]

This issue has been fixed by https://github.com/rack/rack/commit/f690bb71425aa31d7b9b3113829af773950d8ab5

[fcarrega]

The problem is linked to CVE-2019-16782 correction in Rack (see issue https://github.com/rack/rack/issues/1432#issuecomment-571688819).

It seems that a patch has been merged on 1.6 and 2.0 branches of Rack. Related PR here.

[hegwin]

I updated rack to 2.1.1 which still cause this issue. I did this update because there is vunerability for rack =>2.0.0, < 2.0.8.

To resolve the vunerability of rack and to make sidekiq web works, I roll rack back to 2.0.8. It works but makes me feel uneasy. Should we wait rack to fix it? Or some updates in sidekiq web?

[sharshenov]

Fix has been released with rack 2.1.2

[danijel]

With rack 2.1.2 I have a weird issue where only
/sidekiq/retries url is working all others return blank pages

anyone else has this?

rails (6.0.2.1)
sidekiq (5.2.7)
ruby 2.6.1

[sharshenov]

@danijel Have you tried to upgrade to actual version of Sidekiq (6.0.4)? List of changes is not that huge to make upgrade problematic.
rails 6.0.2.1
sidekiq 6.0.4
ruby 2.6.5
rack 2.1.2
Web console works well.

[masutaka]

I have the same problem.

rails (5.2.4.1)
sidekiq (6.0.4)
ruby (2.6.5)
rack (2.1.2)

http://localhost:3000/sidekiq is works well.

However, in the case of https, all sidekiq URL returns blank pages.

[danijel]

@sharshenov Thanks for the proposal, but I can't update sidekiq at the moment because of removal of daemonization and Zeitwerk. Hopefully soon.

[manuelpuyol]

Also not working here

rails (5.2.4.1)
sidekiq (5.2.7)
ruby (2.6.0)
rack (2.1.2)

Also can't update sidekiq right now since I'd have to upgrade redis too.
On localhost web ui works fine, but on production (https) it does not

[mperham]

Please see #4440.

On Feb 4, 2020, at 09:57, Manuel Puyol [e-mail] wrote:


Also not working here

rails (5.2.4.1)
sidekiq (5.2.7)
ruby (2.6.0)
rack (2.1.2)

Also can't update sidekiq right now since I'd have to upgrade redis too.
On localhost web ui works fine, but on production (https) it does not

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or unsubscribe.