Sidekiq: Remove concurrent-ruby dep?

Created on 23 Apr 2018  Â·  2Comments  Â·  Source: mperham/sidekiq

Concurrent-ruby is used very little in Sidekiq and I've heard rumors it is not getting reliable maintenance anymore. Can we vendor what little code we need (is it just the thread-safe Hash for stats in processor.rb?) or reimplement easily?

Most helpful comment

Sidekiq Pro’s usage of c-r is more extensive and therefore not easy to remove.

On Jan 17, 2019, at 06:55, Alexander Mankuta notifications@github.com wrote:

Do you consider dropping concurrent-ruby dependency on sidekiq-pro as well?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

All 2 comments

Do you consider dropping concurrent-ruby dependency on sidekiq-pro as well?

Sidekiq Pro’s usage of c-r is more extensive and therefore not easy to remove.

On Jan 17, 2019, at 06:55, Alexander Mankuta notifications@github.com wrote:

Do you consider dropping concurrent-ruby dependency on sidekiq-pro as well?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

HenleyChiu picture HenleyChiu  Â·  4Comments

michaeldiscala picture michaeldiscala  Â·  4Comments

davidcelis picture davidcelis  Â·  3Comments

bartimaeus picture bartimaeus  Â·  3Comments

sandstrom picture sandstrom  Â·  3Comments