It would be nice to be able to specify that SickChill should prefer x265 content - perhaps not exclusively, but if it's available, prefer it - the file sizes are the chief issue for me.
Also, I note that when SickChill (I tried to use ignored and required words to achieve the result I wanted and noted this) that it appears that the search providers aren't serving up the x265 releases when the searches happen. Is something on my end perhaps not configured correctly leading to this? I can see the listings for the episodes no problem on the NZB sites, but only x264 releases are shown in the log, and then rejected as they don't contain x265 or HEVC or whatever I use... Are they in a different category perhaps?
@DrDrewZA most providers have a separate category for x265/HEVC, so simply adding the quality or required words will not be enough in and of itself unless you use a provider that searches all categories already or does not have them in a separate category. Each torrent provider needs to be updated with code to search for those.
I will see about it in the near future because they are becoming more prevalant and more commonly able to be played.
+1 for this also, Just came here for search for such thing now that all my devices support the format perfect lol
Would it be possible to add it as a sub-option when 720p is selected as the preferred quality or have it in the "allowed" or "preferred" quality lists when using custom?
The usenet indexers I use have HEVC in the same category (HD) as regular h.264 encoded releases and specify HEVC in the release name. However, I am reluctant to add HEVC to the required word list as not all of the shows SickChill is set to grab have HEVC releases published.
This issue has been automatically marked as stale because it has not had activity in 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
-------- Original message --------From: "stale[bot]" notifications@github.com Date: 2019/03/03 09:33 (GMT+02:00) To: SickChill/SickChill SickChill@noreply.github.com Cc: Drew andrew@el.co.za, Mention mention@noreply.github.com Subject: Re: [SickChill/SickChill] Feature Request - HEVC x265 quality (#5250) This issue has been automatically marked as stale because it has not had activity in 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
โYou are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/SickChill/SickChill","title":"SickChill/SickChill","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/SickChill/SickChill"}},"updates":{"snippets":[{"icon":"PERSON","message":"@stale in #5250: This issue has been automatically marked as stale because it has not had activity in 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.\n"}],"action":{"name":"View Issue","url":"https://github.com/SickChill/SickChill/issues/5250#issuecomment-468997164"}}}
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/SickChill/SickChill/issues/5250#issuecomment-468997164",
"url": "https://github.com/SickChill/SickChill/issues/5250#issuecomment-468997164",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
This issue has now been unmarked as "stale"
I use X265 normally now.. The criteria should be expanded to include X265.. I have to select by using custom/Unknown and put wanted HEVC. But it puts all files in the Amber backlog queue.. I would want to have a 1080p X265 version when available for future use but may have a 1080p x264 at the outset.. It usually takes about 6 hours for the X265 to turn up.
Instead of setting the quality as unknown and getting either 1080 OR 720 etc, I still have the required words x265, hevc, and ignored x264
I stopped auto updates, and edited common.py at line 387 from
"return Quality.UNKNOWN if result is None else result"
to
"return Quality.HDTV if result is None else result"
Thanks,
I'm new to sickchill so will keep updates..
I suppose I can keep a copy and replace if there is an update? Will try it
Terry
Mobile 07703476261
On Mon, 8 Apr 2019, 09:15 herbi3, notifications@github.com wrote:
Instead of setting the quality as unknown and getting either 1080 OR 720
etc, I still have the required words x265, hevc, and ignored x264I stopped auto updates, and edited common.py at line 387 from
"return Quality.UNKNOWN if result is None else result"
to
"return Quality.HDTV if result is None else result"โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250#issuecomment-480731293,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC16oJC15g1yN1NmRd2DmATTnZWt2x4rks5vevp-gaJpZM4ZYV0a
.
Although HEVC is not a quality, but 720p is not either a quality.
720p is a measure of resolution.
Quality is the combination of resolution, codec and bandwidth.
Correct! However, sickchill is unable to identify some releases because it has HEVC instead of HDTV in the release name.. Incredibly frustrating, but this has fixed it until support comes in later.
Some release names that sickchill can't natively identity are The Simpsons S30E19 1080p HEVC x265-MeGusta.
Normally releases have names like The Simpsons S30E19 1080p HDTV x264
The two simple changes can be made.
As i have found multiple times a episode gets placed as unknown SDTV when it's a 720p HEVC.
I found that in ./sickchill/tagger/episode.py you have a function that looks for X265 but the code is broken.
return '' if not (self.avc[:-1] == '5') else self.avc
self.avc[:-1] will return x26 which given that if not then it will always return ''
the correct line should be
return '' if not (self.avc[-1:] == '5') else self.avc
then the second fix is under ./sickbeard/common.py I added ep.hevc to the HDTV entries to make sure it labels them correctly.
``` @staticmethod
def scene_quality(name, anime=False): # pylint: disable=too-many-branches, too-many-statements
"""
Return The quality from the scene episode File
:param name: Episode filename to analyse
:param anime: Boolean to indicate if the show we're resolving is Anime
:return: Quality
"""
if not name:
return Quality.UNKNOWN
name = ek(path.basename, name)
result = None
ep = EpisodeTags(name)
if anime:
sd_options = tags.anime_sd.search(name)
hd_options = tags.anime_hd.search(name)
full_hd = tags.anime_fullhd.search(name)
ep.rex[b'bluray'] = tags.anime_bluray
# BluRay
if ep.bluray and (full_hd or hd_options):
result = Quality.FULLHDBLURAY if full_hd else Quality.HDBLURAY
# HD TV
elif not ep.bluray and (full_hd or hd_options):
result = Quality.FULLHDTV if full_hd else Quality.HDTV
# SD DVD
elif ep.dvd:
result = Quality.SDDVD
# SD TV
elif sd_options:
result = Quality.SDTV
return Quality.UNKNOWN if result is None else result
# Is it UHD?
if ep.vres in {2160, 4320} and ep.scan == 'p':
# BluRay
full_res = (ep.vres == 4320)
if ep.avc and ep.bluray:
result = (Quality.UHD_4K_BLURAY, Quality.UHD_8K_BLURAY)[full_res]
# WEB-DL
elif (ep.avc and (ep.itunes or ep.amazon or ep.netflix)) or ep.web or ep.hevc:
result = (Quality.UHD_4K_WEBDL, Quality.UHD_8K_WEBDL)[full_res]
# HDTV
elif ep.avc and ep.tv == 'hd':
result = (Quality.UHD_4K_TV, Quality.UHD_8K_TV)[full_res]
# Is it HD?
elif ep.vres in {1080, 720}:
if ep.scan == 'p':
# BluRay
full_res = (ep.vres == 1080)
if ep.avc and (ep.bluray or ep.hddvd):
result = (Quality.HDBLURAY, Quality.FULLHDBLURAY)[full_res]
# WEB-DL
elif (ep.avc and (ep.itunes or ep.amazon or ep.netflix)) or ep.web or ep.hevc:
result = (Quality.HDWEBDL, Quality.FULLHDWEBDL)[full_res]
# HDTV
elif ep.avc and ep.tv == 'hd':
result = (Quality.HDTV, Quality.FULLHDTV)[full_res] # 1080 HDTV h264
# MPEG2 encoded
elif all([ep.vres == 1080, ep.tv == 'hd', ep.mpeg]):
result = Quality.RAWHDTV
elif all([ep.vres == 720, ep.tv == 'hd', ep.mpeg]):
result = Quality.RAWHDTV
elif (ep.res == '1080i') and ep.tv == 'hd' and (ep.mpeg or (ep.raw and ep.avc_non_free)):
result = Quality.RAWHDTV
elif not ep.vres and ep.netflix or ep.amazon or ep.itunes:
result = Quality.HDWEBDL
elif ep.hrws:
result = Quality.HDTV
elif ep.hevc:
result = Quality.HDTV
# Is it SD?
elif ep.xvid or ep.avc:
# SD DVD
if ep.dvd or ep.bluray:
result = Quality.SDDVD
# SDTV
elif ep.res == '480p' or any([ep.tv, ep.sat, ep.web]):
result = Quality.SDTV
elif ep.dvd:
# SD DVD
result = Quality.SDDVD
elif ep.tv:
# SD TV/HD TV
result = Quality.SDTV
return Quality.UNKNOWN if result is None else result
```
for downloading I added the Required Words: x265,HEVC in the tvshow this works will until an update and I don't know github to make a pull request i'm hoping someone else can and add these fixes in.
@gramimoss Checkout the following diff and tell me if that looks like your changes. If so, I can make a pull request.
https://github.com/zanloy/SickChill/commit/287f331280a54b64901d600c62ced31a487626d7
@gramimoss Checkout the following diff and tell me if that looks like your changes. If so, I can make a pull request.
Thanks for doing the commit, sorry i'm still learning GIT and all it's wonders.
That looks like my one :D
So what settings in SickChill will this allow in the preferred quality? At
the moment it's only mcgusta posting X265 and always has hevc. Not very
consistent at the moment..
Be good to get 720p at first and 1080p when available... (can take a week).
Terry
On Fri, 12 Apr 2019, 15:29 Graeme Moss, notifications@github.com wrote:
@gramimoss https://github.com/gramimoss Checkout the following diff and
tell me if that looks like your changes. If so, I can make a pull request.zanloy@287f331
https://github.com/zanloy/SickChill/commit/287f331280a54b64901d600c62ced31a487626d7Thanks for doing the commit, sorry i'm still learning GIT and all it's
wonders.That looks like my one :D
โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250#issuecomment-482595528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC16oC8es-jm-bwpnF9v0zHrSq2hsFnBks5vgJgrgaJpZM4ZYV0a
.
This patch enables downloading of x265, hevc in a hacky way. We'd need to do some more work to have it as a proper quality
A new X265.. Doesn't have hevc and no mcgusta release yet in 3 days for
thus one. TimeDistortion
Into.The.Badlands.S03E12.Cobra.Fang.Panther.Claw.1080p.AMZN.WEBRip.DDP5.1.X265.10bit-TimeDistortion
Terry
On Sat, 13 Apr 2019, 07:51 WebSpider, notifications@github.com wrote:
This patch enables downloading of x265, hevc in a hacky way. We'd need to
do some more work to have it as a proper qualityโ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250#issuecomment-482782466,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC16oGabBDwdnsHhCyBfiuCv2489Np4Gks5vgX5ZgaJpZM4ZYV0a
.
This patch enables downloading of x265, hevc in a hacky way. We'd need to do some more work to have it as a proper quality
From I'm understanding is everyone on this issue is asking for x265 to be added as a Quality option to sickchill. Could I just say that this is a Huge task and a complete rewrite. Quality is not based on Codec's this would cause a very long list of Quality options. for example:
1080p WEBDL x264
1080p WEBDL x265
1080p WEBDL vp9
1080p WEBDL MPEG4
1080p WEBDL XVID
1080p HDTV x264
1080p HDTV x265
1080p HDTV vp9
1080p HDTV MPEG4
1080p HDTV XVID
720p WEBDL x264
720p WEBDL x265
720p WEBDL vp9
720p WEBDL MPEG4
720p WEBDL XVID
720p HDTV x264
720p HDTV x265
720p HDTV vp9
720p HDTV MPEG4
720p HDTV XVID
Thats just a smal list of what you are asking. SickChill or Sick-Beard went for a very simplistic why using the screen resolution and a few key words in the name to define the Quality.
The "hackey Patch" one fixes a code error in ep.hevc bug and second helps to correctly define the download to at least get a Quality value rather than setting it to Unknown. SickChill has a very nice thing called "Required Words" this help you define what downloads you prefer for example I set my TV shows to have "x265,HEVC" this will search all download options and only download the files that have either of the words.
A new X265.. Doesn't have hevc and no mcgusta release yet in 3 days for thus one. TimeDistortion Into.The.Badlands.S03E12.Cobra.Fang.Panther.Claw.1080p.AMZN.WEBRip.DDP5.1.X265.10bit-TimeDistortion Terry Mobile 07703476261
โฆ
On Sat, 13 Apr 2019, 07:51 WebSpider, @.*> wrote: This patch enables downloading of x265, hevc in a hacky way. We'd need to do some more work to have it as a proper quality โ You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5250 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AC16oGabBDwdnsHhCyBfiuCv2489Np4Gks5vgX5ZgaJpZM4ZYV0a .
That is a problem with your download source. mcgusta is a Bot that downloads and then transcodes to x265 sometime the BOT stops working and misses a few episodes. The name you listed is a x265-HEVC codec file so you would be downloading a 1080p WEBDL it would be a x265.
I'm ok that I can grab what I need.. It is the backlog process that us
causing pain.. A simple option to switch off the Amber backlog would work
OK.. And the ability to re assign them..
Terry
On Sun, 14 Apr 2019, 15:16 Graeme Moss, notifications@github.com wrote:
This patch enables downloading of x265, hevc in a hacky way. We'd need to
do some more work to have it as a proper qualityFrom I'm understanding is everyone on this issue is asking for x265 to be
added as a Quality option to sickchill. Could I just say that this is a
Huge task and a complete rewrite. Quality is not based on Codec's this
would cause a very long list of Quality options. for example:1080p WEBDL x264
1080p WEBDL x265
1080p WEBDL vp9
1080p WEBDL MPEG4
1080p WEBDL XVID
1080p HDTV x264
1080p HDTV x265
1080p HDTV vp9
1080p HDTV MPEG4
1080p HDTV XVID
720p WEBDL x264
720p WEBDL x265
720p WEBDL vp9
720p WEBDL MPEG4
720p WEBDL XVID
720p HDTV x264
720p HDTV x265
720p HDTV vp9
720p HDTV MPEG4
720p HDTV XVID
Thats just a smal list of what you are asking. SickChill or Sick-Beard
went for a very simplistic why using the screen resolution and a few key
words in the name to define the Quality.The "hackey Patch" one fixes a code error in ep.hevc bug and second helps
to correctly define the download to at least get a Quality value rather
than setting it to Unknown. SickChill has a very nice thing called
"Required Words" this help you define what downloads you prefer for example
I set my TV shows to have "x265,HEVC" this will search all download options
and only download the files that have either of the words.A new X265.. Doesn't have hevc and no mcgusta release yet in 3 days for
thus one. TimeDistortion
Into.The.Badlands.S03E12.Cobra.Fang.Panther.Claw.1080p.AMZN.WEBRip.DDP5.1.X265.10bit-TimeDistortion
Terry Mobile 07703476261
โฆ <#m_5947809791650037319_>
On Sat, 13 Apr 2019, 07:51 WebSpider, @.*> wrote: This patch enables
downloading of x265, hevc in a hacky way. We'd need to do some more work to
have it as a proper quality โ You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#5250 (comment)
https://github.com/SickChill/SickChill/issues/5250#issuecomment-482782466>,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC16oGabBDwdnsHhCyBfiuCv2489Np4Gks5vgX5ZgaJpZM4ZYV0a
.That is a problem with your download source. mcgusta is a Bot that
downloads and then transcodes to x265 sometime the BOT stops working and
misses a few episodes. The name you listed is a x265-HEVC codec file so you
would be downloading a 1080p WEBDL it would be a x265.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250#issuecomment-482985392,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC16oCpfp1y-wnwOSVMFb1na5lNmCQ1dks5vgzhLgaJpZM4ZYV0a
.
Ok, and thanks
So what do I do to apply this fix? Is there a patch or is it a manual edit? .. And what should I set the required quality to be.. I want x265 720p at first the 1080p when and if available?
X264 should not be in the quality logic for HDTV.. X266 is now underway and is likely to become the standard. X265 (probably interim) is working fine on Xbox. What about a codec switch.. Which will insert your preference into the logic.
Still nothing going to be fixed for this?
It needs to be in the quality logic, 265, 266 etc because releases have this in the name. Current if it contains these, by default it wont snatch it.
All I can recommend for everyone is the above fix and keep your updates disabled until the fix is pulled in.
I'm doing the grab via rss sabnzb looking for the 1080p version fron my
shows. and letting sickchill grab the 720p version.. Hopefully first.
I have over 2000 shows in backlog Amber.
Not nice..
Terry
Mobile 07703476261
On Thu, 25 Apr 2019, 10:59 herbi3, notifications@github.com wrote:
Still nothing going to be fixed for this?
It needs to be in the quality logic, 265, 266 etc because releases have
this in the name. Current if it contains these, by default it wont snatch
it.All I can recommend for everyone is the above fix and keep your updates
disabled until the fix is pulled in.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250#issuecomment-486608548,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVIDK3NB3CM4GE2A2WXLPSF6ILANCNFSM4GLBLUNA
.
Okay?
On 27 Apr 2019, at 3:22 am, Terry Bannon notifications@github.com wrote:
I'm doing the grab via rss sabnzb looking for the 1080p version fron my
shows. and letting sickchill grab the 720p version.. Hopefully first.I have over 2000 shows in backlog Amber.
Not nice..
Terry
Mobile 07703476261
On Thu, 25 Apr 2019, 10:59 herbi3, notifications@github.com wrote:
Still nothing going to be fixed for this?
It needs to be in the quality logic, 265, 266 etc because releases have
this in the name. Current if it contains these, by default it wont snatch
it.All I can recommend for everyone is the above fix and keep your updates
disabled until the fix is pulled in.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250#issuecomment-486608548,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVIDK3NB3CM4GE2A2WXLPSF6ILANCNFSM4GLBLUNA
.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
few commits coming through, but still no HEVC support......
Please send me a bunch of file names for hevc that I can test with. I need all variances. You can change the show name in the file name and post a list here for safety
Although HEVC is not a quality, but 720p is not either a quality.
720p is a measure of resolution.
Quality is the combination of resolution, codec and bandwidth.
Actually, quality is combination of resolution, codec, and SOURCE (dvd, bluray, hdtv, webdl, etc)
The issue is because MeGusta is releasing files with no source, and 2 codec/compression in the file name. HEVC and x265 are essentially the same thing. HEVC is the compression and x265 and h.265 are 2 codecs that can use that compression. The 4th thing for quality that we ignore is the container (mkv, avi, mp4, etc)
Up until this week all 720p versions were marked HDTV..
I only use the mcgusta HEVC and they are consistently named.
Terry
Mobile 07703476261
On Fri, 31 May 2019, 11:04 miigotu, notifications@github.com wrote:
Please send me a bunch of file names for hevc that I can test with. I need
all variances. You can change the show name in the file name and post a
list here for safetyโ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVIAURNYCBLARAPX3Y3DPYDZZFA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUZUZA#issuecomment-497654372,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVIBTFUTOYFYPS3AN5RLPYDZZFANCNFSM4GLBLUNA
.
Correct. Testing on this end, if it doesn't have HDTV in the name, it's not detected at all. Unless the hacky fix is applied and updates are disabled.
x265 by MeGusta are typically always named the same (Just without the typical HDTV in the name..)
I've added the naming from a random search below
Elementary.S07E02.1080p.HEVC.x265-MeGusta
Marvels.Cloak.And.Dagger.S02E10.1080p.HEVC.x265-MeGusta
Forged.in.Fire.S06E15.720p.HEVC.x265-MeGusta
American.Ninja.Warrior.S11E01.720p.HEVC.x265-MeGusta
A few other examples from other sources
Star.Trek.Discovery.S00E01.Runaway.1080p.NF.WEB.DL.DDP5.1.HDR.HEVC-MZABI
Yes, these are movies, but the similar name applies
Captain.Marvel.2019.2160p.WEB-DL.DD+5.1.HEVC-MOMA
Captain.Marvel.2019.2160p.WEB-DL.DDP5.1.Atmos.HDR.HEVC-BLUTONiUM
Aquaman.2018.UHD.BluRay.2160p.TrueHD.Atmos.7.1.HEVC.REMUX-FraMeSToR
here's a few more, I'll have to modify the searcher to default to HDTV for hevc for the following to be picked up as HDTV
2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Ignoring result Chernobyl.S01E04.720p.HEVC.x265-MeGusta.
2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Don't want this quality, ignoring found result for Chernobyl S01E04 with quality Unknown
2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Any,Best = [ 720p HDTV, 1080p HDTV, 720p WEB-DL, 1080p WEB-DL, 720p BluRay, 1080p BluRay ] [ None ] Found = [ Unknown ]
2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Using cached parse result for: Chernobyl.S01E04.720p.HEVC.x265-MeGusta
The 1080p versions come up HDTV though..
Terry
Mobile 07703476261
On Sat, 1 Jun 2019, 00:27 herbi3, notifications@github.com wrote:
here's a few more, I'll have to modify the searcher to default to HDTV for
hevc for the following to be picked up as HDTV2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Ignoring
result Chernobyl.S01E04.720p.HEVC.x265-MeGusta.2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Don't
want this quality, ignoring found result for Chernobyl S01E04 with quality
Unknown2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Any,Best
= [ 720p HDTV, 1080p HDTV, 720p WEB-DL, 1080p WEB-DL, 720p BluRay, 1080p
BluRay ] [ None ] Found = [ Unknown ]2019-06-01 09:21:38 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Using
cached parse result for: Chernobyl.S01E04.720p.HEVC.x265-MeGustaโ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVIFQYR3XMVHZ4H4VRELPYGX4BA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWS5KY#issuecomment-497888939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVIAEZWJI6C32SP4TB4LPYGX4BANCNFSM4GLBLUNA
.
Do you have any examples to share with the class, Terry?
The 1080p versions are grabbed from sabnzb rss feed from my cart.. They are
handed to sickchill and all come up HDTV. The 720p versions are snached by
sickchill and handed to sabnzb.. Could this be it?
Terry
Mobile 07703476261
On Sat, 1 Jun 2019, 11:21 herbi3, notifications@github.com wrote:
Do you have any examples to share with the class, Terry?
โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVICCHXIVKR2NTZ6BJV3PYJEPJA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWW5QPA#issuecomment-497932348,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVIGU5B36M3MJXQVYMLLPYJEPJANCNFSM4GLBLUNA
.
.... thanks for the reminder, Terry..
...Do you have any debug logs helping us here?
I think I need to add a search setting for "Allow HEVC/x265" so that people who want them can get them, but people who do not dont randomly just start getting them on this next update. This does not require a new set of qualities, because HEVC is not a quality it is a compression/codec.
That sounds like a good compromise and would probably be easier to implement than add a set of new Qualities that specifically reference HEVC
HEVC isnt a quality, so adding qualities makes zero sene :)
Neither is 720p, 1080p, h264, h265, xvid. Basically everything Sickchill uses to determine the quality, isn't actually a quality....
Quality, like i said before, is the combination of resolution, source, codec/compression, and container. We ignore containers, and codec is easily selectable outside of our quality system.
If anyone can, please test the feature/5250 branch and report back. You will need to enable HEVC support in search settings at the bottom of the episode search tab. Nothing else should need to be changed.
https://github.com/SickChill/SickChill/pull/5519/files
>>> from sickbeard.common import Quality
>>> Quality.qualityStrings[Quality.scene_quality('The.Hot.Zone.S01E04.1080p.HEVC.x265-MeGusta')]
u'N/A'
>>> Quality.qualityStrings[Quality.scene_quality('The.Hot.Zone.S01E04.720p.HEVC.x265-MeGusta')]
u'N/A'
>>> sickbeard.QUALITY_ALLOW_HEVC = True
>>> Quality.qualityStrings[Quality.scene_quality('The.Hot.Zone.S01E04.1080p.HEVC.x265-MeGusta')]
u'1080p HDTV'
>>> Quality.qualityStrings[Quality.scene_quality('The.Hot.Zone.S01E04.720p.HEVC.x265-MeGusta')]
u'720p HDTV'
Granted, there is a drawback here because since these releases do not include a source tag, we use HDTV as a catchall, and I am ok with that.
[local] :: [e6f8e56] Exception while searching local. Error: IndexError('string index out of range',)
AA IndexError: string index out of range AA return '' if not (self.avc[-1] == '5') else self.avc AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickchill\tagger\episode.py", line 184, in hevc AA elif ep.hevc and not sickbeard.QUALITY_ALLOW_HEVC: AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickbeard\common.py", line 346, in scene_quality AA quality = Quality.scene_quality(title, anime) AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickchill\providers\GenericProvider.py", line 353, in get_quality AA quality = self.get_quality(item, anime=show.is_anime) AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickchill\providers\GenericProvider.py", line 180, in find_search_results AA searchResults = curProvider.find_search_results(show, episodes, search_mode, manualSearch, downCurQuality) AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickbeard\search.py", line 474, in searchProviders 2019-06-02 13:06:23 DEBUG SEARCHQUEUE-MANUAL-360893 :: [local] :: Traceback (most recent call last): AA IndexError: string index out of range AA return '' if not (self.avc[-1] == '5') else self.avc AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickchill\tagger\episode.py", line 184, in hevc AA elif ep.hevc and not sickbeard.QUALITY_ALLOW_HEVC: AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickbeard\common.py", line 346, in scene_quality AA quality = Quality.scene_quality(title, anime) AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickchill\providers\GenericProvider.py", line 353, in get_quality AA quality = self.get_quality(item, anime=show.is_anime) AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickchill\providers\GenericProvider.py", line 180, in find_search_results AA searchResults = curProvider.find_search_results(show, episodes, search_mode, manualSearch, downCurQuality) AA File "C:\Users\Administrator\AppData\SickChill\SickChill\sickbeard\search.py", line 474, in searchProviders AA Traceback (most recent call last):
Working well!
2019-06-02 13:17:12 INFO SEARCHQUEUE-MANUAL-360893 :: [local] :: Performing episode search for Chernobyl 2019-06-02 13:17:12 INFO SEARCHQUEUE-MANUAL-360893 :: Beginning manual search for: [Chernobyl - S01E03 - Open Wide, O Earth] 2019-06-02 13:16:51 INFO SEARCHQUEUE-MANUAL-360893 :: Downloading Chernobyl.S01E04.720p.HEVC.x265-MeGusta from local 2019-06-02 13:16:51 INFO SEARCHQUEUE-MANUAL-360893 :: [local] :: Quality of Chernobyl.S01E04.720p.HEVC.x265-MeGusta is 720p HDTV 2019-06-02 13:16:51 INFO SEARCHQUEUE-MANUAL-360893 :: [local] :: Release: Chernobyl.S01E04.MULTi.1080p.HDTV.x264-HYBRiS doesn't contain any of megusta, ignoring it 2019-06-02 13:16:51 INFO SEARCHQUEUE-MANUAL-360893 :: [local] :: Quality of Chernobyl.S01E04.MULTi.1080p.HDTV.x264-HYBRiS is 1080p HDTV 2019-06-02 13:16:51 INFO SEARCHQUEUE-MANUAL-360893 :: [local] :: Release: chernobyl.s01e04.720p.webrip.x264-tbs doesn't contain any of megusta, ignoring it 2019-06-02 13:16:51 INFO SEARCHQUEUE-MANUAL-360893 :: [local] :: Quality of chernobyl.s01e04.720p.webrip.x264-tbs is 720p WEB-DL
Please stay on that branch for a few days to test. I'll be adding some tests to make sure this functionality is not broken in the future.
This has made it into the develop branch. You will need to enable HEVC support in search settings at the bottom of the episode search tab. Nothing else should need to be changed.
Thanks.. When's it due?
Terry
Mobile 07703476261
On Mon, 3 Jun 2019, 12:05 miigotu, notifications@github.com wrote:
This has made it into the develop branch. You will need to enable HEVC
support in search settings at the bottom of the episode search tab. Nothing
else should need to be changed.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVIAOTGCTVVJNY6SVBM3PYT3CVA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZB4WA#issuecomment-498212440,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVIFOQUOPJ7YC5RECL7LPYT3CVANCNFSM4GLBLUNA
.
If you want to help test if the feature meets the needs, it is available in the develop branch right now. Please feel free to run develop to see if it works for you and provide us feedback.
When develop is deemed stable enough, it will be promoted to become the new general release. This usually takes a number of days.
I'll wait thanks.. Too much on my plate
Terry
Mobile 07703476261
On Mon, 3 Jun 2019, 15:29 WebSpider, notifications@github.com wrote:
If you want to help test if the feature meets the needs, it is available
in the develop branch right now. Please feel free to run develop to see if
it works for you and provide us feedback.When develop is deemed stable enough, it will be promoted to become the
new general release. This usually takes a number of days.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVIDTOYUN5PTIEUOTQDLPYUTEFA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZSRNY#issuecomment-498280631,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVID7NZWIXCEOQU3W5D3PYUTEFANCNFSM4GLBLUNA
.
So far it is working well!
On 4 Jun 2019, at 7:09 am, Terry Bannon notifications@github.com wrote:
I'll wait thanks.. Too much on my plate
Terry
Mobile 07703476261
On Mon, 3 Jun 2019, 15:29 WebSpider, notifications@github.com wrote:
If you want to help test if the feature meets the needs, it is available
in the develop branch right now. Please feel free to run develop to see if
it works for you and provide us feedback.When develop is deemed stable enough, it will be promoted to become the
new general release. This usually takes a number of days.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVIDTOYUN5PTIEUOTQDLPYUTEFA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZSRNY#issuecomment-498280631,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVID7NZWIXCEOQU3W5D3PYUTEFANCNFSM4GLBLUNA
.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
So what quality is set?
Terry
Mobile 07703476261
On Mon, 3 Jun 2019, 22:22 herbi3, notifications@github.com wrote:
So far it is working well!
On 4 Jun 2019, at 7:09 am, Terry Bannon notifications@github.com
wrote:I'll wait thanks.. Too much on my plate
Terry
Mobile 07703476261
On Mon, 3 Jun 2019, 15:29 WebSpider, notifications@github.com wrote:
If you want to help test if the feature meets the needs, it is
available
in the develop branch right now. Please feel free to run develop to
see if
it works for you and provide us feedback.When develop is deemed stable enough, it will be promoted to become the
new general release. This usually takes a number of days.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVIDTOYUN5PTIEUOTQDLPYUTEFA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZSRNY#issuecomment-498280631
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAWXVID7NZWIXCEOQU3W5D3PYUTEFANCNFSM4GLBLUNA.
โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.โ
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SickChill/SickChill/issues/5250?email_source=notifications&email_token=AAWXVIDAOB6XLPVNZE4WJN3PYWDPFA5CNFSM4GLBLUNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW2XLBA#issuecomment-498431364,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXVIERLUWUAN2SLGXS5VTPYWDPFANCNFSM4GLBLUNA
.
ill wait until it hits master but looking forward to it
I tested this on the dev branch. I am on a readynas 214 (firmware 6.10.1)

Ticking the box DOES allow HEVC/x265 releases to be included in results.

It doesn't seem to prioritize them over other releases, which is what would be really helpful.
You can add "HEVC" to your 'Required Words', but then the search will fail if an HEVC release isn't available, and ideally it would fallback to non-HEVC releases.
It doesn't seem to prioritize them over other releases, which is what would be really helpful.
I think this is because SickChill thinks WEB-DL is higher Quality then HDTV that is why it downloaded a x264 rather then the x265.
I guess you would have to force HEVC to be a higher Quality then everything else and only then would it look for a lower quality if it can't find an HEVC version.
You would have to have it fit in the defined code in sickbeard/common.py
Determine quality and set status codes
"""
NONE = 0 # 0
SDTV = 1 # 1
SDDVD = 1 << 1 # 2
HDTV = 1 << 2 # 4
RAWHDTV = 1 << 3 # 8 -- 720p/1080i mpeg2 (trollhd releases)
FULLHDTV = 1 << 4 # 16 -- 1080p HDTV (QCF releases)
HDWEBDL = 1 << 5 # 32
FULLHDWEBDL = 1 << 6 # 64 -- 1080p web-dl
HDBLURAY = 1 << 7 # 128
FULLHDBLURAY = 1 << 8 # 256
UHD_4K_TV = 1 << 9 # 512 -- 2160p aka 4K UHD aka UHD-1
UHD_4K_WEBDL = 1 << 10 # 1024
UHD_4K_BLURAY = 1 << 11 # 2048
UHD_8K_TV = 1 << 12 # 4096 -- 4320p aka 8K UHD aka UHD-2
UHD_8K_WEBDL = 1 << 13 # 8192
UHD_8K_BLURAY = 1 << 14 # 16384
ANYHDTV = HDTV | FULLHDTV # 20
ANYWEBDL = HDWEBDL | FULLHDWEBDL # 96
ANYBLURAY = HDBLURAY | FULLHDBLURAY # 384
It doesn't seem to prioritize them over other releases, which is what would be really helpful.
I think this is because SickChill thinks WEB-DL is higher Quality then HDTV that is why it downloaded a x264 rather then the x265.
Makes sense. I suspect most people who are interested in HEVC would want it to trump other releases _at a given resolution_, but who knows!
I guess you would have to force HEVC to be a higher Quality then everything else and only then would it look for a lower quality if it can't find an HEVC version.
You would have to have it fit in the defined code in sickbeard/common.py
Yep. And then you're back to the problem of having a list of Qualities that is really long and cumbersome.
And there's STILL the issue that the HEVC releases tend to be delayed somewhat compared to the standard ones, so if you don't require HEVC, then you'll probably end up getting a standard one anyway for new releases.
IN ANY CASE, the update does seem to be pulling HEVC releases WITHOUT resorting to setting the quality to Unknown, AND nothing seems to have broken for me. So that's good! ๐
In skytorrents.py
just add x265 here :
self.urls = {'config_provider_home_uri': self.url_base,
'search': self.url_base + '?category=show&sort=created&query=%s+x265&page=%s'}
and restart sickrage/beard...