Sickchill: Problem with name searching for anime [torrent]

[ShiiroSan]

Branch/Commit: 696b852 / Master branch
OS: Debian 8
What you did: Search for an anime episode
What happened: Searcher can't find the episode
What you expected:
Logs:

2017-01-07 18:25:24 DEBUG    SEARCHQUEUE-MANUAL-295068 :: [NyaaTorrents] :: GET URL: https://www.nyaa.se/?sort=2&term=Dragon+Ball+Super+20&cats=1_0&page=rss&order=1 [Status: 200]
https://www.nyaa.se/?page=search&cats=0_0&filter=0&term=dragon+ball+super+020

Looks like it's because the searcher do "anime_name episode_number" as most of torrent website work like that "anime_name 0episode_number".
Fast example:
https://www.nyaa.se/?page=search&cats=0_0&filter=0&term=dragon+ball+super+20
https://www.nyaa.se/?page=search&cats=0_0&filter=0&term=dragon+ball+super+020

First 15 pages, seconds only 1 pages with best results in first entry

[SickRage2]

Thanks for the issue report! Before a real human comes by, please make sure your report has all the below criteria checked

• [ ] Include basic information: Branch/Commit, OS, What you did, What happened, What you expected
• [ ] Enable debug logging (be sure to disable after the bug is fixed)
• [x] Post debug logs, either inline (for smaller logs) or using gist
• [x] Please wrap inline logs inside ``` and ``` for readability

Please make sure you also read how to create an issue and followed all of the steps.

The title should describe your issue. Having "SR not working" or "I get this bug" for 100 issues, isn't really helpful. We will close issues if there isn't enough information.

Sometimes the devs may seem like grunts and respond with short answers. This isn't (always) because the dev hates you, but because he's on mobile or busy fixing bugs. If something isn't clear, please let us know, and this bot may get updated to automatically answer you.

Thanks!

[miigotu]

Fixed in develop, let me know and ill merge to master if it works.

[h3llrais3r]

EDIT: did not look good. This PR does not give results for anime series which are numbered like 01.

[ShiiroSan]

Don't really understand. What you mean is that 001 will be included in the search of 01? Cause natively this don't work.

[miigotu]

@h3llrais3r your PR undoes the fix for this issue. 001 is anime scene standard for absolute numbering, 01 is incorrectly named.

[h3llrais3r]

@miigotu I's possible that's 001 is the standard, but a lot of anime series do not use this. Using 01 solves the issue and even 001 will be found with 01.
FYI also * is using 01 for searching for anime. See https://github.com/*/*/blob/master/*/providers/generic_provider.py#L463

[h3llrais3r]

@miigotu I looked at the original code and it was using only only 1 digit for single digit episodes.
So I do understand the change but as far as I can see you have a lot more anime series with double digit series than 3 digit series. So I would really consider changing it to 2 digits instead of three.
I'll create a new PR to change it at all levels because I forgot a few in my original PR.

[h3llrais3r]

I did some more research: the reason why the example in the original example did not work, is because it matches all the episodes with 720p in the name (because we are searching for 20).
You will probably have the same issue when searching for 72 (720p), 10,08 and 80 (1080p).
However, all others episode do work while with the current code (3 digit) you never get any result.
So hopefully this can convince you to merge my PR 😄