Showdown: openLinksInNewWindow breaks _em_ markup

Created on 25 Apr 2017  路  5Comments  路  Source: showdownjs/showdown

When running the converter with openLinksInNewWindow set to true, it seems to break the conversion of the _underscore_ => <em>underscore</em> markup.

example string:
My [link](http://example.com) is _important_

when I convert it with openLinksInNewWindow set false, I receive (as expected):
<p>My <a href="http://example.com">link</a> is <em>important</em></p>

when I convert it with openLinksInNewWindow set true, I receive:
<p>My <a href="http://example.com">link</a> is _important_</p>
the word important no longer wrapped with the em tag.

Conversion of *star* => <em>star</em> works fine.

bug

All 5 comments

Verified

should be fixed now

Much appreciated @tivie! When are you planning to merge this to master?

Soon. I'm planning the next release but wanted to merge https://github.com/showdownjs/showdown/pull/358 this PR that is dependent on creating a couple of tests. As soon as #358 is merged, a new showdown release will be published.

Thanks for the quick fix @tivie - I can confirm that works for me!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

reisraff picture reisraff  路  5Comments

jendewalt picture jendewalt  路  4Comments

oscarmorrison picture oscarmorrison  路  4Comments

evanplaice picture evanplaice  路  3Comments

qyvlik picture qyvlik  路  4Comments