Shopify_app: When shopify_app used in automated tests - user_agent_can_partition_cookies fails with exception NoMethodError: undefined method `match' for nil:NilClass

Created on 20 Nov 2018 · 5Comments · Source: Shopify/shopify_app

Steps to repeat:

Create the rspec test which calls the fullpage_redirect_to charge.confirmation_url to simulate the redirect to Charge Confirmation URL.
See that the test fails with the following error:

NoMethodError: undefined method `match' for nil:NilClass

NoMethodError:
       undefined method `match' for nil:NilClass
     # /Users/maris/.rvm/gems/ruby-2.4.4/gems/shopify_app-8.4.0/lib/shopify_app/controller_concerns/itp.rb:38:in `user_agent_can_partition_cookies'
     # /Users/maris/.rvm/gems/ruby-2.4.4/gems/shopify_app-8.4.0/lib/shopify_app/controller_concerns/itp.rb:10:in `set_test_cookie'
     # ./spec/controllers/charge_controller_spec.rb:22:in `block (3 levels) in <top (required)>'

Code which fails

File: shopify_app-8.4.0/lib/shopify_app/controller_concerns/itp.rb:38:in 'user_agent_can_partition_cookies'

    def user_agent_can_partition_cookies
      user_agent = BrowserSniffer.new(request.user_agent).browser_info

      is_safari = user_agent[:name].match(/Safari/)

      return false unless is_safari

      user_agent[:version].match(/12.0/)
    end

Explanation:

During the tests, the user_agent is an empty Hash.
So user_agent[:name] produces nil result.

Suggested change:

    def user_agent_can_partition_cookies
      user_agent = BrowserSniffer.new(request.user_agent).browser_info

      is_safari = user_agent[:name]&.match(/Safari/)

      return false unless is_safari

      user_agent[:version]&.match(/12.0/)
    end