Shopify_app: For embedded apps, signing out will show the install page inside of the store's admin panel.

Created on 30 Aug 2016  路  2Comments  路  Source: Shopify/shopify_app

Perhaps redirect them to their store's apps page instead?

feature request

Most helpful comment

I agree. Devise implements this well with methods called something like after_sign_out_path and after_sign_in_path that you can override when necessary. Maybe we could do the same?

I don't actually use this myself, either, except in development, which is how I noticed it. I just thought it was an odd choice to redirect the user to an install page that renders inside of the admin panel after they sign out of an app they already have installed.

All 2 comments

It's because of this code here: https://github.com/Shopify/shopify_app/blob/master/lib/shopify_app/sessions_concern.rb#L36

Maybe logout_url could be a setting.

Also what is your flow the results in the user logging out? I haven't built this into any of our apps so I am curious what it looks like.

I agree. Devise implements this well with methods called something like after_sign_out_path and after_sign_in_path that you can override when necessary. Maybe we could do the same?

I don't actually use this myself, either, except in development, which is how I noticed it. I just thought it was an odd choice to redirect the user to an install page that renders inside of the admin panel after they sign out of an app they already have installed.

Was this page helpful?
0 / 5 - 0 ratings