Shields: remove use of componentWillReceiveProps()

Created on 26 Sep 2018  路  1Comment  路  Source: badges/shields

The following lifecycle method are deprecated in react 16.3+

  • componentWillMount
  • componentWillReceiveProps
  • componentWillUpdate

and will be removed in 17: https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html

Fortunately we're not leaning too heavily on them. We have a single use of componentWillReceiveProps() which we will need to remove:

https://github.com/badges/shields/blob/04290e890bcbb27264a69f6693fa27ec4cb69359/frontend/components/markup-modal.js#L34-L54

frontend
Source
picture chris48s
👍1

Most helpful comment

Hi, i would like to fix it :)

picture piekar294 on 19 Oct 2018
🎉2 👍2

>All comments

Hi, i would like to fix it :)

piekar294 picture piekar294 on 19 Oct 2018
🎉2 👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

kerolloz picture kerolloz  路  3Comments
Fazendaaa picture Fazendaaa  路  3Comments
niccokunzmann picture niccokunzmann  路  3Comments
calebcartwright picture calebcartwright  路  3Comments
PyvesB picture PyvesB  路  3Comments