Shields: Our test badge incorrectly stays green
Our tests went red on master a couple days ago. There were failures in the main tests, not just the service tests. The badge has shown passing I think that entire time, and still is. I thought the problem was that Circle was showing results from the most recent tests on any branch instead of just master. However if I get the badge for master, I see the same thing.
https://img.shields.io/circleci/project/github/badges/shields/master.svg
paulmelnikow
All 3 comments
Quick look at this suggests this is because the badge is only looking at the first build status (data[0]), so this will be affecting any users of this badge with >1 pipelines in their build. We should modify this to look at all of the builds in the array.
chris48s
on 22 Jul 2018
Is this still a happening? It looks okay to me (although it's the daily that is failing)
RedSparr0w
on 19 Aug 2018
I reopened this in light of a discussion @chris48s and I were having here: https://github.com/badges/shields/pull/1927#discussion_r211068591.
Sorry I didn't post that before!
paulmelnikow
on 19 Aug 2018
Related issues
najeeb-ur-rehman
路
3Comments
PyvesB
路
3Comments
stclairdaniel
路
3Comments
rominf
路
3Comments
bruno-garcia
路
3Comments
Most helpful comment
Quick look at this suggests this is because the badge is only looking at the first build status (
data[0]), so this will be affecting any users of this badge with >1 pipelines in their build. We should modify this to look at all of the builds in the array.