Shields: CLI raster badges are broken

[paulmelnikow]

As observed at https://github.com/badges/shields/pull/1774/files#r203522813, the CLI isn't generating raster badges correctly.

node lib/badge-cli.js '' '' '#bada55' .png > favicon.png

Observed output:

Expected output:

[platan]

# prepare a test
cat test.sh 
node lib/badge-cli.js '' '' '#bada55' .svg > favicon-tested.svg
grep 'width="22"' favicon-tested.svg

# find a bad commit
git bisect start HEAD 438e47adfb74e9a775e3fed7a5547959f343c009
git bisect run ./test.sh

# result
b216bcc17e667a2fb09bede7be0d1c67e731d767 is the first bad commit

the bad commit -> https://github.com/badges/shields/commit/b216bcc17e667a2fb09bede7be0d1c67e731d767

[platan]

But:

node lib/badge-cli.js '' '' '#bada55' .png > favicon.png

gives me:

• in master
• in 438e47adfb74e9a775e3fed7a5547959f343c009 (random old commit)
• in b216bcc17e667a2fb09bede7be0d1c67e731d767
• in b216bcc17e667a2fb09bede7be0d1c67e731d767 (one commit before b216bcc17e667a2fb09bede7be0d1c67e731d767)

[paulmelnikow]

Seems like this may be a "wontfix," given discussion in #3587 and #3112.

[paulmelnikow]

As discussed at https://github.com/badges/shields/pull/3644#issuecomment-508947740 it seems these work fine on some systems.

I've just upgraded imagemagick, and this is what I'm seeing now:

node lib/badge-cli.js build passed :green .png > mybadge.png

The summary of other discussions we've had is that:

• We want this to work more reliably.
• It'll be through an optionalDependency to keep the gh-badges footprint smaller.
• We can switch from gm / imagemagick to Puppeteer using the more modern rasterization library convert-svg-to-png – that's the one that's being used in svg-to-image-proxy.

[brettz9]

Whenever the change might be made, could the functionality be added on the programmatic side as well?

[paulmelnikow]

This functionality is being removed in #4756, so closing this.