Shields: GitHub tag: wrong value displayed on badge

Created on 10 May 2018  路  6Comments  路  Source: badges/shields

Please compare badge with GitHub API returned values

v1.4.0-alpha.4 should be displayed as the latest version tag.

bug

All 6 comments

@RedSparr0w - is this the same issue that you're looking at in #1628 ?

All tags returned by GH API are valid semvers, I'm not sure #1628 will help.
BTW: GH API for tags is filtering semver compatible tags - "nightly" tag value is not returned (https://github.com/moneymanagerex/moneymanagerex/tags)

@chris48s Was fairly similar, have updated to include this issue also.

Edit: also see https://github.com/npm/node-semver/issues/216 for an explanation on why it works this way by default with maxSatisfying()

Is this definitely the behavior we want? Many of our other version badges ignore prereleases.

I see that #1628 includes a modification to accommodate this, though I wonder if in this case, we should default to ignoring prereleases, and let developers choose if they want to see them.

Thx

Usage:
https://img.shields.io/github/tag-pre/moneymanagerex/moneymanagerex.svg

Was this page helpful?
0 / 5 - 0 ratings

Related issues

marceloboeira picture marceloboeira  路  35Comments

paulmelnikow picture paulmelnikow  路  40Comments

sinedied picture sinedied  路  28Comments

tony19 picture tony19  路  31Comments

un1versal picture un1versal  路  25Comments