Shields: Appveyor tests / same link?!

Created on 7 Nov 2017  路  7Comments  路  Source: badges/shields

Appveyor tests and Appveyor tests branch have the exact same links:
av_tests

bug frontend good first issue

All 7 comments

Looks like this happened in #1065.

An easy fix, PR appreciated.

After the move away from try.html I don't know where to apply the change anymore. :)

It looks like in the mentioned PR he just forgot an appending /master...

Hey there! I believe you have to apply the change to lib/all-badge-examples.js now. 馃槈

@PyvesB thanks ;)

https://github.com/badges/shields/blob/master/lib/all-badge-examples.js#L54

Looking at this and the other badges around, my first thought was we could remove it completely.
But after searching all that file for exampleUri + comparing with the live shields.io page... I'm not certain anymore when we want/need to use that at all.

@tooomm would you be submitting this PR. If not i am happy to help

Regarding the open questions (to me), I'm not submitting a PR @M-ZubairAhmed.

There are a couple other exampleUris that could use fixing. These errors will happen less often now that we're not using try.html. Since we're defining the URIs in JavaScript, and with less duplication, it's a lot clearer what is what.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kirankotari picture kirankotari  路  3Comments

salaros picture salaros  路  3Comments

calebcartwright picture calebcartwright  路  3Comments

najeeb-ur-rehman picture najeeb-ur-rehman  路  3Comments

PyvesB picture PyvesB  路  3Comments