Sherlock: Tor Support On Windows & Linux

[hoadlck]

What is up with the Tor support on Windows? Or in Linux? Does it actually work right for people?

While doing the restructuring, I am testing in more depth as I change the code. And, I discovered that Tor requests were not working for me (I did have the Tor Browser installed).

When I tried to run a query with Tor, I got an uncaught exception that said the following:
OSError: 'tor' isn't available on your system. Maybe it's not in your PATH?

I did some more research, and found the following StackOverflow answer. In the end, it appears that if I have an instance of the Tor browser running, and I tell Sherlock what the Tor control port is, then Sherlock seems to work. Or, at least, it does not throw an error.

Here is the change that I made:
underlying_request = TorRequest(ctrl_port=9151)

It appears that there are ways to install Tor directly in the system. If that is done, then perhaps the specific port that I used above could be changed?

This support was originally added in #31 by @mpieters93.

I think at a minimum there needs to be some changes so that the error message is more graceful. I am not sure of the consequence of changing Sherlock so that the control port is 9151. This needs more research.

[LameLemon]

I tried this on Linux Mint 19

I had to first install tor

apt install tor

Enable Control port by uncommenting the line in/etc/tor/torrc.
Then stop tor from running

/etc/init.d/tor stop

Sherlock gave the correct results using --tor but when I included the --unique-tor flag I wasn't able to get a single result despite leaving it to run for around 12 minutes. No changes were made to the source code, I'm using an up to date version of master (64eb20e03c1bea0bb178e3eb3dcf3fe2e1637a85).

[sdushantha]

@hoadlck Has this issue been fixed?

[hoadlck]

No, I have not done anything more with it.