Shellyforhass: Add brand images to home assistant
In the recent version of Home Assistant brands (logos) of integrations are shown when adding new or view details - https://github.com/home-assistant/frontend/pull/5500
It would be awesome to see SHelly logo there.
Consider adding brands to https://github.com/home-assistant/brands.
Not sure about the name, it should be "shelly", but this integration is named ShellyForHASS?
Maybe it should be renamed?
Misiu
All 28 comments
Will check with Dimitar if and how we can proceed.
Simone
chemelli74
on 10 Apr 2020
Dimitar gave green light.
Need to find the right formats now. Maybe we can try to ask their marketing, but they are rather busy lately.
Simone
chemelli74
on 12 Apr 2020
I have the Shelly logo in vector format so I can fix that!
From: Simone Chemelli notifications@github.com
Sent: Sunday, April 12, 2020 10:47:39 AM
To: StyraHem/ShellyForHASS ShellyForHASS@noreply.github.com
Cc: Subscribed subscribed@noreply.github.com
Subject: Re: [StyraHem/ShellyForHASS] Add brand images to home assistant (#258)
Dimitar gave green light.
Need to find the right formats now. Maybe we can try to ask their marketing, but they are rather busy lately.
Simone
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/StyraHem/ShellyForHASS/issues/258#issuecomment-612583575, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAI5KDTDQSVOVOWKGKQIFGTRMF52XANCNFSM4MFOFDGQ.
hakana
on 12 Apr 2020
@hakana I can prepare images if You share the vector logo.
Misiu
on 15 Apr 2020
I have created the images, if someone can help to do a pull request it will help a lot!
hakana
on 16 Apr 2020
@hakana I can do PR, but what will be the name of integration? I must place images in a folder.
How should I call that folder? shelly?
Ok, got it. Icon name is based on domain, and it is shelly
Misiu
on 16 Apr 2020
Ok, got it. Icon name is based on domain, and it is
shelly
Yes please, go for "Shelly" if the name is the product or "Allterco" if it's the brand.
Simone
chemelli74
on 16 Apr 2020
@chemelli74 I'm waiting for reply on community forum because ShellyForHASS is a custom integration and I'm not sure if this is allowed (sorry for not asking HA devs before)
I'll get back with results and I'll link PR if I get approval.
Misiu
on 16 Apr 2020
Must be the domain name used in plugin and that is shelly
hakana
on 16 Apr 2020
@misiu Any news?
hakana
on 30 Apr 2020
@hakana I've created a thread on forum (https://community.home-assistant.io/t/brands-images-for-custom-integrations/187363) but sadly I didn't get any response.
Sadly custom integrations icons and logos can't be added to brands repo.
Let's wait a bit more. Maybe Home Assistant team will propose a solution
Misiu
on 2 May 2020
@hakana I've created a thread on forum (https://community.home-assistant.io/t/brands-images-for-custom-integrations/187363) but sadly I didn't get any response.
Sadly custom integrations icons and logos can't be added to brands repo.
Let's wait a bit more. Maybe Home Assistant team will propose a solution
Replied to the community thread with my proposal, let's see if they notice it ;-)
Simone
chemelli74
on 2 May 2020
denniswham
on 8 May 2020
Misiu
on 8 May 2020
I've noticed that custom integrations should be added to wheels - https://github.com/home-assistant/wheels-custom-integrations
@chemelli74 could you create PR for that?
Misiu
on 8 May 2020
What will wheels-custom-integration do?
hakana
on 8 May 2020
What will wheels-custom-integration do?
To be honest I have no ideas :smile: but I see HACS is added there.
Misiu
on 8 May 2020
@misiu, thanks for adding the PR!
hakana
on 8 May 2020
I have added a PR to Wheels now, can't hurt ;)
hakana
on 8 May 2020
My PR got merged so I think we can close this issue.
Took long but finally the integration will look fine :)
Misiu
on 9 May 2020
Do you know when will working, guess it will need a build?
hakana
on 10 May 2020
Do you know when will working, guess it will need a build?
Next release is expected for Wednesday.
Simone
chemelli74
on 10 May 2020
@hakana @chemelli74 I think images don't require a new release as they are served from a separate repo.
Misiu
on 10 May 2020
@hakana @chemelli74 I think images don't require a new release as they are served from a separate repo.
Let's see it that way: even if I did a reboot of my 0.110.x HA test environment, I still don't see the images.
Simone
chemelli74
on 10 May 2020
Works on 0.110.0.dev20200510
chemelli74
on 11 May 2020
Works in 0.109.x also!
hakana
on 11 May 2020
Awesome 🎉🎉🎉
Misiu
on 11 May 2020
Thanks @Misiu for the help!
hakana
on 11 May 2020
Related issues
balloob
·
3Comments
PeteHassio
·
10Comments
chemelli74
·
9Comments
JonahKr
·
7Comments
Misiu
·
11Comments
Most helpful comment
Works on 0.110.0.dev20200510