Sharex: Images appear corrupted on upload

[TNTUP]

Hi, I've updated ShareX today and when I take a screenshot the image is corrupted, Is it due to my ISP or computer? I've tried rebooting another PC and it still happens. Would uninstalling/reinstalling will fix it?

Here's a proof like this one: http://i.qcfb.ca/20160819023320.png In FireFox the image wont load due it contains errors but chrome loads it but incomplete. I've downloaded the file from my webserver and it appears corrupted. It cannot be my webserver, nothing has changed since :/

Tried downgrading, didn't work... I guess my installation of ShareX is now corrupted?

Tried uninstalling, no luck

EDIT: Changed buffer setting and it appears solved huh.. I've left it to 512KB and I had no issues since today.... Still happens with larger png images, I guess setting at 1KB Buffer size would solve my issue... Why uploading uses 256kb/s upload? Thats why I've increased the buffer size :/

EDIT2: Still buggy, idk why it does that... never happened

[Jaex]

Is local saved image corrupt too?

[TNTUP]

Nevermind, setting back to 32kb buffer appears to be fixed.... That's strange, it never happened in the past.... Was always at 512Kb....

The local file isn't, while uploading is. Probably either the buffer size idk not supported by the SFTP protocol?

[TNTUP]

Setting to 32kb buffer size does not happen (I hope!, it does upload at 800kb+/s so thats fine), but if higher/lower it happens (I tested 1, 4, 8, 512, 1MB, 2MB etc..)

[Jaex]

How buffer size can be causing corrupt upload?

[TNTUP]

at 32kb: http://i.qcfb.ca/20160819033021.png
at 64kb: http://i.qcfb.ca/20160819033042.png
and... I guess even if I go higher would be the same, leeme try 128kb http://i.qcfb.ca/20160819033118.png

It happens with the FTP uploader set (SFTP), I tested with imgur with no issues

[Techbot121]

this also happened to me at higher buffer sizes, setting it down to 32kb fixed it.

[Jaex]

Was this issue always exist and nobody reported it before or new SFTP library update caused it?

[Techbot121]

nope it just happened after the recent update.

[TNTUP]

@Jaex Same as Techbot, Probably the SFTP lib you say (that's I use since 2012) and its the first time I see that issue xD

[Jaex]

Try downloading previous version portable (https://github.com/ShareX/ShareX/releases/download/v11.1.0/ShareX-portable.zip) and copy Renci.SshNet.dll file from it to your ShareX folder to replace new one. That way you can test is new library causing it.

[TNTUP]

Permission Issue? I've replaced the file with the portable one

System.IO.FileLoadException: Impossible de charger le fichier ou l'assembly 'Renci.SshNet, Version=2016.0.0.0, Culture=neutral, PublicKeyToken=1cee9f8bde3db106' ou une de ses dépendances. La définition trouvée du manifeste de l'assembly ne correspond pas à la référence de l'assembly. (Exception de HRESULT : 0x80131040)
Nom de fichier : 'Renci.SshNet, Version=2016.0.0.0, Culture=neutral, PublicKeyToken=1cee9f8bde3db106'
à ShareX.UploadersLib.FileUploaders.SFTP.Dispose()
à ShareX.UploadersLib.FileUploaders.SFTP.Upload(Stream stream, String fileName)
à ShareX.WorkerTask.UploadData(IGenericUploaderService service, Stream stream, String fileName)
à ShareX.WorkerTask.DoUpload(Int32 retry)

[Jaex]

Replacing with old library dll not always works :(

[TNTUP]

I've replaced the file (I was lazy to reinstall and didn't do a backup dll) within the recent portable zip file and buffer size was at 64 and still buggy, Reverting to 32kb fixes it. Is it Renci.SshNet's side then?

[Jaex]

If it were to do with ShareX then normal uploads would corrupt too because using same transfer method.

[TNTUP]

Atleast the workaround is setting the buffer size to 32 :)

[Nathanael-Mtd]

Same problem with SFTP on my side, and I confirm about the workaround, it works fine with 32kb.

[Jaex]

Nothing changed in ShareX SFTP codes and only SFTP library updated which means problem can't be to do with ShareX.
So problem must be reported in: https://github.com/sshnet/SSH.NET
I don't have SFTP account, so I can't report it myself without be able to reproduce it myself.

[TNTUP]

If you have a linux serveur with SFTP/SSH server you can, setting your webserver to point a directory. Though this is not my application (ShareX) Idk if they would fix on their side.

[Jaex]

I don't have any server. I always implement FTP, SFTP stuffs blindly without be able to test them. But of course I ask few friends to test it.

[Nathanael-Mtd]

I confirm, after building latest ShareX version with old SSH.NET, the problem is linked to SSH.NET. The only one solution for now if going back to the old version or/and make a report in SSH.NET GitHub.

[TNTUP]

@Nathanael-Mtd I did a report, but if tecky dev stuff I cannot answer xD

[Nathanael-Mtd]

@TNTUP Nice, btw if you want the new version without the problem of buffer > http://l.i4g.me/ShareX-11.2.1-setup.exe

[TNTUP]

@Nathanael-Mtd Thanks! Although I've set the buffer to 32kb and i dont remember why its use XD (too lazy to read the docs)

@Jaex I've opened up an issue on their bug tracker what they can do XD if they say tricky stuff I couldn't answer since thats not my software :)

[Jaex]

@TNTUP GitHub automatically linked that issue with this issue so I will receive emails when there is new messages in that issue too.

[TNTUP]

Ahh nice, didn't knew that. Like if I mention your name it automatically notify you? Sweet XD Sorry for those "double mention" xD

[Jaex]

Yes.

[TNTUP]

The dev responded he will probably fix it this weekend, bugfix next weekend :D

[jasondavis]

Where can I set the buffer size?

Running Windows 7 with ShareX 11.2.1

---

UPDATE

Nevermind I think I found it.... BTW changing to 32 seems to have resolved my FTP image issue, thanks!

Application Settings >> Upload >> Buffer Size >> 32kb

[Nathanael-Mtd]

@jasondavis In application parameters I think. But you can use my build instead if you want (7 posts before)

[jasondavis]

@Nathanael-Mtd Thanks. BTW does your version simple change that 1 buffer setting value or it does other things too? Thanks

[Nathanael-Mtd]

No, just I just made a version without the problem on old SSH.NET build. There are also a build with the new SSH.NET build, but I didn't uploaded yet.

[RenanGBarreto]

I just confirm that this bug exists on a preinstalled Windows 10 64bits machine.
Changing the buffer to 32kb solves the issue.

[Jaex]

Returning to SSH.NET.2014.4.6-beta2 until new build release.

[Jaex]

After 3 years finally non beta build which don't have this bug released!