Shards: shard.lock file adds new dependency from shards install

Created on 12 Jul 2018  路  2Comments  路  Source: crystal-lang/shards

Hello.
I noticed if shard.yml has

dependencies:
  kemal:
    github: sdogruyol/kemal
    branch: master

and shard.lock says

  kemal:
    github: sdogruyol/kemal
    commit: f916bad09568582a74730a38b40bdeceaab46a10

if I do a

$ shards install

it adds a new dependency into shard.lock that is in kemal/master, but isn't in the commit I am currently using....

In this case it added

+  exception_page:
+    github: crystal-loot/exception_page
bug

Most helpful comment

Shards is confused between branch: master and the locked commit. It probably resolves dependencies using the shard.yml from the master branch, when it should really use the locked commit...

The install command should inject the locked constraints sooner, in order to force a locked commit.

All 2 comments

Shards is confused between branch: master and the locked commit. It probably resolves dependencies using the shard.yml from the master branch, when it should really use the locked commit...

The install command should inject the locked constraints sooner, in order to force a locked commit.

Perfect, works great now, thank you!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

straight-shoota picture straight-shoota  路  4Comments

anatol picture anatol  路  3Comments

vladfaust picture vladfaust  路  5Comments

ysbaddaden picture ysbaddaden  路  7Comments

InstanceOfMichael picture InstanceOfMichael  路  5Comments