Shardingsphere: Optimize proxy instance definition in registry center

Created on 22 Jun 2020  ·  11Comments  ·  Source: apache/shardingsphere

According to the suggestions made by @dongzl and @kimmking in the issue #5627 , use ip+port instead of ip + threadId to define proxy instance in registry center is better.

/
├─orchestration-namespace
├─orchestration-name
│ ├─registry
│ │ ├─instances
│ │ │ ├─127.0.0.1@3307@xxx
│ │ │ ├─127.0.0.1@3308@xxx
governance good first issue

All 11 comments

Hi!
I believe OrchestrationInstance holds this data of ip + thread-id which needs to be changed.
I am not sure how to get the port on which the instance is running.

@swayamraina For proxy,the port can be passed to ShardingOrchestrationFacade when proxy starts, and for jdbc, thread id is better.

@menghaoranss can you please review yhe PR for any improvements.

@menghaoranss can you please review yhe PR for any improvements.

Of course, i will take the time to review, thanks for you contribution.

@swayamraina Expecting your forward.

@swayamraina any problems?

Will update the code as per review. Thanks!

@swayamraina The pr #6187 you submitted has lasted too long, there may already be a lot of conflicts, can you please resubmit another pr based on our discussion?

sure @menghaoranss will sync the PR

sure @menghaoranss will sync the PR

merged! thansk for your contribution.

Thanks, will try to contribute more :)

Was this page helpful?
0 / 5 - 0 ratings