Some cases include YAML inline string for testing orchestration persistent which are hard to read.
It is better to put the YAML inline string into YAML file.
Some test cases which need to be refactored:
Can I pick this issue? This is my first issue so is it ok if I work on ConfigCenterTest file first and raise PR ?
@terrymanu We are optimizing the unit test coverage of the orchestration module now,I will optimize the above test classes at the same time.
@menghaoranss hey if you are busy with something and need some hand then please let me work on this , I also want to contribute to open source community :-)
@sukumaar good ,you can pick a task to respond to.
what can i do for this case?
can i try the test ConfigCenterTest ?
can i try the test
ConfigCenterTest?
of course,looking forward to your pull request.
can i try the test
ConfigCenterTest?
hey is it possible for you to pick other test ? , because I have kinda started working on it.
May I try SchemaChangedListenerTest this one?
can i try the test
ConfigCenterTest?hey is it possible for you to pick other test ? , because I have kinda started working on it.
yeah i can pick other @sukumaar
Please ref #5629, use
@SneakyThrows
private String readYAML(final String yamlFile) {
return Files.readAllLines(Paths.get(ClassLoader.getSystemResource(yamlFile).toURI())).stream().map(each -> each + System.lineSeparator()).collect(Collectors.joining());
}
to load file content
what can i do for this question?
can i try the test:OrchestrationSpringBootRegistryEncryptTest
@tomakemyself @zengzhihong, welcome
Can I try the test: OrchestrationSpringBootRegistryMasterSlaveTest
Most helpful comment
yeah i can pick other @sukumaar