Shardingsphere: Use YAML configuration instead of java configuration for DataSource test

Created on 7 Mar 2020  ·  6Comments  ·  Source: apache/shardingsphere

YAML configuration is clear and easy to understand.
Using YAML configuration to instead of java configuration for DataSource test is better.
The test cases need to be refactored:

  • [x] AbstractEncryptJDBCDatabaseAndTableTest for encrypt rule creation
  • [x] AbstractMasterSlaveJDBCDatabaseAndTableTest for master slave rule creation
  • [x] AbstractShardingJDBCDatabaseAndTableTest for sahrding rule creation
encrypt good first issue test

All 6 comments

I want to do it

@HetaoWang Welcome on board.

@terrymanu Can i take this ?. Thanks

@ranjeet-floyd there are 3 sub-tasks, you may take the last one if you interest.

@terrymanu ok i will take AbstractShardingJDBCDatabaseAndTableTest for sahrding rule creation Thanks

@terrymanu Raised PR for AbstractEncryptJDBCDatabaseAndTableTest. https://github.com/apache/incubator-shardingsphere/pull/4871

Please let me if this is right way , then will do others.

Was this page helpful?
0 / 5 - 0 ratings