Shaka-player: Audio + Role Shows Roles From Video Stream

[jakubvojacek]

Have you read the FAQ and checked for duplicate open issues?:
yes
What version of Shaka Player are you using?:
2.5 beta
Can you reproduce the issue with our latest release version?:
no (i mean 2.4.5)
Can you reproduce the issue with the latest code from master?:
yes
Are you using the demo app or your own custom app?:
both
If custom app, can you reproduce the issue using our demo app?:
using nightly build at https://nightly-dot-shaka-player-demo.appspot.com/demo/ yes
What browser and OS are you using?:
mac os & chrome
What are the manifest and license server URIs?:
MPD is available at https://goo.gl/79XrFA and for license URL you can enter anything, to have the playback isnt important.

What did you do?
Loaded the MPD

What did you expect to happen?
to open up the available audio languages and see correct roles

What actually happened?
There should only be one audio language marked with main role (the Russian language). In works well in https://shaka-player-demo.appspot.com/demo/ but in the https://nightly-dot-shaka-player-demo.appspot.com/demo it does not

vs screenshot from stable

[vaage]

This came from a change I made. I changed getAudioLanguageAndRoles to work on the tracks, instead of streams. I will address it.

[vaage]

This should be fixed now. @jakubvojacek could you verify on your end that this has in-fact resolved your issue and report back to us?

[jakubvojacek]

Thank you @vaage, I already tried but it's failing due to mux.js error I mentioned here https://github.com/google/shaka-player/issues/1404#issuecomment-448328362.

[vaage]

Okay, I will close this one for now. If it is still an issue after #1404 is resolved, please re-open this issue.

[jakubvojacek]

Hello @vaage , after applying https://github.com/google/shaka-player/commit/337c1a9f02d84a54613d0f2240186b9d88fed162 I can confirm that your fix has helped and the issue is resolved, thank you again 👍