Shadowsocks-windows: The pac rule in 4.1.9 is not compatible with old ones

Created on 8 Jan 2020  ·  5Comments  ·  Source: shadowsocks/shadowsocks-windows

4.1.9:

var __PROXY__ = '127.0.0.1:1080'
var proxy = __PROXY__;

While the old version is:

var proxy = '__PROXY__';

This change will cause all of the old pac.txt broken 😕. I personally don't think it's appropriate. At least a breaking change notice should be announced.

Most helpful comment

Another reason is resource management, every resource file has two copy: exe builtin one, and one in file system. I'm planning remove builtin one to simplify this problem, but the project only in my fork now, not sure it's a good idea.

https://github.com/studentmain/shadowsocks-windows/tree/no-builtin-blob

All 5 comments

Maybe is this change:
ad36bf6

Yes, my mistake, haven't tested with custom PAC. It's impratical to roll back, so we need document this now.

For breaking change notification see #2758.

We need design and document PAC rule API, see #2746

(考虑AFK一阵子,最近代码质量不行)

Another reason is resource management, every resource file has two copy: exe builtin one, and one in file system. I'm planning remove builtin one to simplify this problem, but the project only in my fork now, not sure it's a good idea.

https://github.com/studentmain/shadowsocks-windows/tree/no-builtin-blob

改好就能用了3Q

Close as expected.

Was this page helpful?
0 / 5 - 0 ratings