Sfdx-git-delta: EmailTemplate members with antislashes on Windows should be with slashes

Created on 14 Apr 2021 · 10Comments · Source: scolladon/sfdx-git-delta

On Windows, generated EmailTemplate items in package.xml contain antislashes instead of slashes

So to be able to deploy after, I have to replace \ by /

Example :

  <types>
    <name>EmailTemplate</name>
    <members>unfiled$public</members>
    <members>unfiled$public\ChantierJ14DateDemarrage</members>
    <members>unfiled$public\ChantierReferenceMarketing</members>
    <members>unfiled$public\NotifDemandePromo</members>
  </types>

should be

  <types>
    <name>EmailTemplate</name>
    <members>unfiled$public</members>
    <members>unfiled$public/ChantierJ14DateDemarrage</members>
    <members>unfiled$public/ChantierReferenceMarketing</members>
    <members>unfiled$public/NotifDemandePromo</members>
  </types>

Would it be possible to solve this issue ? Or tell me where to do it, so I can make a PR ? Thanks :)

bug

Source

nvuillam

👍1

All 10 comments

Hi @nvuillam!

Thanks for raising this issue!

The code of the plugin is platform robust because it uses path.sep everywhere. It even normalize git path returned from git diff --name-status (which is POSIX) to be compliant with the running architecture.

The issue here is that we use this path separator everywhere and also in the metadata component.
The fix will be to generate the package.xml using POSIX file path separator then

I'll try to find some times EOW to identify where it comes from and fix it.

If you are available for the PR review that would be awesome!

scolladon on 14 Apr 2021

❤1

@scolladon Sure I can validate your future PR by fetching the PR branch and test locally with sfdx plugins:link ;)
ps: thanks for your great tool :)

nvuillam on 14 Apr 2021

👍1

@nvuillam PR ready for review :)

scolladon on 17 Apr 2021

@scolladon I'm sorry ... but not working yet :/

nvuillam on 17 Apr 2021

mmmm I didn't checkout the good branch, sorry, i check again ^^

nvuillam on 17 Apr 2021

Works like a charm :) :)

Thanks a lot for your reactivity, and for your great plugin that allows us to not have to update manually package.xml & destructiveChange.xml in our sfdx-projects ;)