Add application examples of:
geom_sf in github version of ggplot2 #270 #311 st_joinaggregatest_agrst_erase, #346 sf was not loaded, #374 st_simplify does, and doesn't do, #381One suggestion I would make is to have st_as_sf(foo, coords = c(lon, lat)) be much more prominent in the vignette/examples. I think it is a very common workflow but I didn't discover it until I had fairly extensive sf experience.
Maybe reading in a data.frame instead of reading from meuse in the second vignette would help.
I second @jsta 's suggestion.
As per bullet-point on mapview, how can I help? Do you just want to add mapview(x) calls to the examples? Or a specific vignette regarding example applications (these do exist in mapview documentation - maybe some sf data construction in those rather than the usage of the mapview example data)?
I think it would be most useful to start a new vignette on plotting: base, ggplot, mapview, tmap, pointing to their own longer materials.
For the mapview part we would need to pretty much completely point to the respective documentation chapters as the vignette will grow too large if we include too many widgets (at least if it is intended as a CRAN vignette).
Are these chapters online?
I had sth like that in mind. How do you manage your vignettes don't end up on CRAN, and how could you add a CRAN vignette that points to those on github?
Essentially, all sf has to do is create a plot vignette that makes you hungry and points to all these vignettes, right?
We don't have a CRAN vignette in mapview as I had no luck so far creating a meta-vignette that points to these. I tried with just links to these chapters, but since they are in the same package subfolder the CRAN check complains. So far, the only solution that I found for such big chapters to be acceptable for CRAN is to not have a CRAN vignette at all and state both the docs and the vignette folders in .Rbuildignore.
Rather than directories you could specify file names in .Rbuildignore, and leave one in that then points users to the external ones.
I think I tried that, but CRAN check still complained about something... I can't really remember the details, but I will re-investigate and see if I can get it to work.
I build my final pkg using the command
USER=CRAN R CMD build sf
and then conditional execution sections of R scripts could look like:
if (Sys.getenv("USER") != "CRAN")
...
Added vignette 5 (plotting) and 6 (miscellaneous).
Most helpful comment
One suggestion I would make is to have
st_as_sf(foo, coords = c(lon, lat))be much more prominent in the vignette/examples. I think it is a very common workflow but I didn't discover it until I had fairly extensive sf experience.Maybe reading in a data.frame instead of reading from
meusein the second vignette would help.