Sevtech-ages: Villager Name Discrepancies

[CrossMyDNA]

Some of the villagers show one name/job when hovering over them, but a different one when activating a trade. Here are the ones I've found:

• Leatherworker displays as butcher
• Fletcher displays as farmer, shepherd, or fisherman
• Cartographer displays as librarian
• Fisherman displays as fletcher
• Farmer displays as fletcher

[Darkosto]

Definitely a bug, but I'm not too sure on how to fix it yet. I'll dig into more later on. Thanks!

[Jandakast]

This is an issue with the Neat mod and has been open with no comment or tag since Aug 5, 2016.

https://github.com/Vazkii/Neat/issues/18

[codetaylor]

So I traced around in the code a bit and it looks like the issue is caused because the client doesn't have the proper villager career ID. The server sends a packet to tell the client to open the GUI and provides the client with the correct villager name at that time.

My understanding is that entities use the DataManager to sync data with the client. The villager profession is contained in the DataManager and therefore gets synced, however, since the villager career ID is not contained in the DataManager, it doesn't get synced with the client.

This could very well be a vanilla or Forge issue.

[asiekierka]

Charset 0.5.0's latest build works around it, but the module has to be enabled manually.

It synchronizes careerId from server to client and sets careerLevel to 1 if it's equal to 0 (aka not set), as otherwise populateBuyingList() (which is called by getDisplayName() for some reason I don't understand) will reset careerId to a random one. Synchronizing careerLevel is unnecessary so I left it be - not too much spoiling for the user...

[asiekierka]

Apparently, the correct solution is to run getDisplayName() on the server. Welp.

[Darkosto]

Yep, so this is going to be fixed by Vazkii to just give villagers the "Villager" name instead of their jobs. It's the best fix that can be done and should work just fine :D

[VallenFrostweaver]

I would suggest that if the villager names are not changed (as they are not as of Beta4) to add in both name types into any quest descriptions. For example: On the quest Lost but Now Found: Saying to "Trade for a map from a Cartographer villager" could be changed to "Trade for a map from a Cartographer or Librarian villager" which would allow for either the bug to be fixed or not in the future.