Settings-view: Images broken on available updates

[clemmy]

[mnquintana]

I've reproduced this with Atom 1.0.3-0fe4183, but not consistently. I think this can happen in any view with package cards though - not just the Updates panel.

/cc @benogle

[rjv]

Seeing same issue on Windows 7, Atom v1.0.3.

[jensljungblad]

+1

[vjandrea]

+1

[joshschumacher]

I've been annoyed by this small bug for a long time too, decided to try to look into it. Opened up the inspector view (View > Developer > Toggle Developer Tools) to inspect one of the failing avatars. Weird thing was, inspector thought the image was just fine - it showed a popup preview when I hovered over the image src (file:///Users/josh/Library/Application%20Support/Atom/Cache/settings-view/tststs-1445582599869). Went to view that image directly on the filesystem and it was hunky-dory. Reloaded the Updates panel to watch a network inspector load and what do you know - all of the images loaded.

Hoping maybe the repro steps will help someone that is familiar with the code base because now it's working for me and I can't reproduce ¯_(ツ)_/¯

[defeated]

Confirmed this is still happening in Atom 1.5.3 -

[davidspiess]

I think the problem is a wrong mime type. I can see two image request in my dev tools. The first call with type text/plain which obviously is broken.

[senoadiw]

Deleting the settings-view dir in %userprofile%\AppData\Roaming\Atom\Cache and reloading the window seems to regenerate the icon cache.

[deakster]

Deleting the folder @senoadiw mentioned did fix it for me briefly, but the issue came back pretty quickly.

[berniedurfee]

+1

Atom 1.6.2
Mac OS X - 10.10.5 - Yosemite

[nicholasdunbar]

I am having this problem as well.

+1

Atom 1.6.2
Mac OS X - 10.11.4 - El Capitan

[dbwest]

+1

[zachjs]

+1

[digeomel]

+1 on atom 1.7.4 - RHEL 7 behind proxy

[yustnip]

The same. Also through proxy.

[ghost]

+1 atom 1.7.4 Ubuntu 16.04 but no proxy.

[danielmahon]

+1 Atom 1.8 OSX El Capitan

[MichaelAquilina]

+1 Ubuntu Atom 1.7.4 no proxy

[rdmcgregor]

+1 Atom 1.8 OSX El Capitan

[jmdelros]

+1 Atom 1.9 on Windows 10 behind a proxy

[MichaelAquilina]

Random note while I was looking into this. I tried inspecting using the developer tools and I set the width of the img element to 20 and it seemed to fix itself. Dont know if this is just a side effect of the browser reloading the image after it becomes available though.

[bastilian]

I think I found what the issue is.

When the images are requested, it might happen that they time out, but a file still gets saved, which is not an image and therefore causes broken avatar images.

813 will include a fix that removes the file in case of an error and hopefully will address the issue.

[50Wliu]

@bastilian I think that's a different issue (#327). The issue here is that _all_ avatars are showing as broken on the Available Updates page while they work fine on others, such as the Install pane.

[cvega]

+1 Atom 1.9.6, OSX - El Capitan (10.11.6)

[damieng]

I'm not convinced this is a different underlying issue - it also goes direct to the cache and attempts to load files just like the other pages and they both display the broken indicator if that file is corrupt/zero bytes.

[damieng]

Rewritten a bunch of the avatar image caching code to better handle bad responses, errors and non-image bodies and not cache them. This should solve these issues and the ones in #327 better than the size check (it would previously cache 500 errors as an image) and is better performing.