Serving: deploy_test and queue_test go file clean up

Created on 17 Mar 2020  ·  11Comments  ·  Source: knative/serving

The deploy_test and queue_test go files contain a lot of repetitive and duplicated code that should be extracted into helpers.
My guesstimate is that we can save probably some 30-40% of the files. And they are more than 2k lines together. This is a sizable readability improvement.

In what area(s)?

/area API
/area test-and-release

/kind good-first-issue

areAPI aretest-and-release good first issue help wanted kinbug kincleanup kingood-first-issue ¯\_(ツ)¯

All 11 comments

/good-first-issue

@markusthoemmes:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Do you mean that moving the repetitive code into deploy_test_helps and queue_test_helps ?

No, just locally extract functions.

Also they can be reused from another file, since they're in the same package.

/reopen

@vagababov: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

นอกจากนี้ยังสามารถนำมาใช้ซ้ำจากไฟล์อื่นเนื่องจากอยู่ในแพ็คเกจเดียวกัน

@vagababov you've done quite a bit here lately. Is this done to your content?

yeah
should be ok
/close

@vagababov: Closing this issue.

In response to this:

yeah
should be ok
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vtereso picture vtereso  ·  5Comments

ysjjovo picture ysjjovo  ·  5Comments

mattmoor picture mattmoor  ·  7Comments

VladimirSmogitel picture VladimirSmogitel  ·  7Comments

ZhiminXiang picture ZhiminXiang  ·  3Comments