Serving: Can't deploy v0.9.0 monitoring to kube 1.16

[duglin]

In what area(s)?

/area monitoring

What version of Knative?

v0.9.0

Expected Behavior

No errors

Actual Behavior

unable to recognize "monitoring.yaml": no matches for kind "Deployment" in version "extensions/v1beta1"
unable to recognize "monitoring.yaml": no matches for kind "DaemonSet" in version "extensions/v1beta1"

Steps to Reproduce the Problem

Just deploy monitoring.yaml to kube 1.16
It appears these are no longer in beta and are in apps/v1 now

[vagababov]

https://github.com/knative/serving/pull/5605/files fixed that at head.
I am not sure if we're going to backport it into 0.9 though.
/cc @mattmoor

[vagababov]

/cc @mdemirhan

[duglin]

I'd vote +1 to backporting since people will most likely want to use 0.9 with 1.16

[duglin]

Will close once that chat finishes since this is a dup of https://github.com/knative/serving/issues/5599

[dgerd]

This seems like an easy backport and something that has the potential to unblock a number of users. I would be in favor of this.

[shturec]

Same experience with v0.10.0 on a clean k8s 1.16

[stephenhandley]

seeing same issue as @shturec

[airwavetechio-gh]

Here's what I changed to make it work, but I'm not 100% sure it's right. Everything seemed to deploy okay.

...
---
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: node-exporter
  namespace: knative-monitoring
spec:
  selector:
    matchLabels:
      app: node-exporter
  template:
    metadata:
      labels:
        app: node-exporter
...

[arthurtsang]

@airwavetechio-gh you're 7hrs before me! v0.10.0 somehow missed one DaemonSet (node-exporter) which is still using extensions/v1beta1 and missing the selector

[pomazanbohdan]

apiVersion: apps/v1
kind: DaemonSet
metadata:
name: node-exporter
namespace: knative-monitoring
spec:
selector:
matchLabels:
app: node-exporter
template:
metadata:
labels:
app: node-exporter

error: error validating "monitoring.yaml": error validating data: [ValidationError(DaemonSet.spec.template.spec): unknown field "selector" in io.k8s.api.core.v1.PodSpec, ValidationError(DaemonSet.spec.template.spec): unknown field "template" in io.k8s.api.core.v1.PodSpec, ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec]; if you choose to ignore these errors, turn validation off with --validate=false

[sravankumar777]

Hi,
I observed same error with installation of knative-monitoring with v1.10.0 on Minikube.

is this issue still not fixed for backport versions?

[mdemirhan]

Will work on fixing the daemonset in head and backport changes needed to 0.9 and 0.10.

[markusthoemmes]

So as it stands, 0.11 and 0.12 do not cause any trouble I presume? Can we close this?

[mdemirhan]

0.11 and 0.12 has the fixes and those should be used instead of 0.9 for this fix.