Serving: Activator leaks metrics publicly

Created on 18 Sep 2018  路  3Comments  路  Source: knative/serving

Expected Behavior

When making a request to a deactive service /metrics, I expect the service to activate and handle the request.

Actual Behavior

The activator's /metrics endpoint hijacks the request and returns it's own internal metrics

Steps to Reproduce the Problem

  1. create a service
  2. wait for it to scale to zero
  3. make a request to the service with the path /metrics
  4. see that the response is activator's metrics

Additional Info

Metrics and other control plane request handlers must run on a different port in order to not collide with the data plane.

areautoscale kinbug

Most helpful comment

I think we should move the metrics exporting to another port.

All 3 comments

/cc @akyyy @josephburnett

I think we should move the metrics exporting to another port.

/cc @mdemirhan

Was this page helpful?
0 / 5 - 0 ratings