Service-catalog: Access to the service catalog types

Created on 16 May 2018  路  10Comments  路  Source: kubernetes-sigs/service-catalog

As a user of the service catalog, I would like to have access to the service catalog types in my go program without having to vendor in the entire service catalog

lifecyclfrozen

Most helpful comment

I like dep, but I think eventually we might need to do a repo split.

All 10 comments

This would be really great. I have an issue open around this also https://github.com/kubernetes-incubator/service-catalog/issues/1367

I wonder if a proposal to break out the client into a separate package would help move this further?

@shawn-hurley See my comment on the other issue for an example of how to vendor just the client types that you need:

https://github.com/kubernetes-incubator/service-catalog/issues/1367#issuecomment-389589332

Basically dep will keep in vendor only the packages that you are using (like our typed client) and will prune the other stuff in the service catalog repo.

Let me know if that works for you. Hopefully we can build out doc to explain this better, if you would be interested in helping with that, let me know.

I like dep, but I think eventually we might need to do a repo split.

Maybe we do syncs when we do a tagged push?

Ah, you are suggesting a mirrored repo just for the client. I didn't quite understand that when I read through it the first time. 馃榾

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/assign @jberkhahn
Does go modules solve this? Maybe this can be part of the movement to a new repo home?

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

/lifecycle frozen

Was this page helpful?
0 / 5 - 0 ratings