Serverless-offline: 3.25.5 breaks compatibility with serverless-webpack

[arabold]

I still need to dive into this to find the root cause, but it seems that changes in the last 3.25.5 update broke startup of serverless-offline when used in combination with serverless-webpack. Either one of both plugins "does something wrong".

With 3.25.4 startup works as expected and the last log line is Serverless: Offline listening on http://localhost:3000. However, after updating to 3.25.5 it just _hangs_ and never starts up the web server.

[pmuens]

I can confirm that. In my case I don't use any other plugin.

Here's the serverless.yml to reproduce the bug:

service: test

provider:
  name: aws
  runtime: nodejs8.10

plugins:
  - serverless-offline

functions:
  hello:
    handler: handler.greeter
    events:
      - http:
          path: /hello-world
          method: POST
          cors: true

Version 3.25.4 workd, whereas 3.25.5 just returns without starting the server.

---

Edit: Here's the comparison between 3.25.4 and 3.25.5.

[pmuens]

@arabold I found the issue and PRed the fix via #446.

/cc @arabold

[pmuens]

🤔 not sure if this is the end of the story...

Now it's not terminating if I hit CTRL+C. It just hangs in the Offline halting... state.

[pmuens]

Just updated #446 so that it reverts #437.

[dherault]

v3.25.6 !

[pmuens]

v3.25.6 !

Thanks @dherault 👍