Server: [Files sharing] Log message: "/appinfo/app.php is deprecated"

[Valdnet]

I keep getting the following message in my logs:

Debug   files_sharing   /appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.    
2020-09-25T14:36:30+0200
Debug   files_sharing   /appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.    
2020-09-25T14:36:29+0200
Debug   files_sharing   /appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.    
2020-09-25T14:36:29+0200
Debug   files_sharing   /appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.    
2020-09-25T14:36:29+0200
Debug   files_sharing   /appinfo/app.php is deprecated, use \OCP\AppFramework\Bootstrap\IBootstrap on the application class instead.    
2020-09-25T14:36:29+0200

Server configuration

Database:
phpMyAdmin

PHP version:
7.3.16

Nextcloud version: (see Nextcloud admin page)
20.0.0 RC2

App:
Files sharing
1.12.0

[kesselb]

Increase the log level to 1 or higher. It's expected for level debug to log deprecated calls.

[Qinxz1414]

I had the same problem.

[ChristophWurst]

Debug message -> expected.

[andreas-p]

Core apps really shouldn't trigger deprecation messages, but get fixed (arguably prior to a release).
Or other way round: if the implementation of files_sharing is considered stable and future proof, NC shouldn't mark it as deprecated.

[ChristophWurst]

@andreas-p could you check if this green button is blocked for you?

/s

[andreas-p]

@ChristophWurst No it's not. If you're suggesting I should create a PR for this (officially closed!) issue: For my debugging purposes, I commented out the deprecation message in lib/private/legacy/OC_App.php. files_sharing/appinfo/app.php looks different from what I'm familiar with, so I refrained from digging there.

[working-name]

As a user my pull request would simply be disabling the message altogether. But that might be useful for developers. Idea is.. if your "expected debug message" takes a dump on the UI which is user-facing then your "feature" is as useful as this guy's facial tattoo:

Maybe another solution would be to keep deprecation messages away from the UI. Or give the user a way to use filters?

Otherwise this is how much fun you can have as a user trying to debug why the email app chokes on ssl connections:
much fun - 37MB gif

[ChristophWurst]

As a user

So as a user you're complaining about a debug log output. Seriously, why do you worry about this so much? You enable debug mode for a few secs to gather some info, then you disable it again.

Now tell me: would you rather have a silent log where we, the maintainers, can't help you solve an issue due to the lack of information?

[working-name]

you're complaining about a _debug log output_

No, actually I'm not complaining about a debug log output, and I've already conceded that deprecation notices might be useful for developers. What I'm specifically stating is that deprecation notices at a rate of 3/second is a useless thing in the UI.

Now tell me: would you rather have a silent log where we, the maintainers, can't help you solve an issue due to the lack of information?

I thought deprecation notices are more of a reminder to later tackle the phased out code. Am I wrong?

[ChristophWurst]

With the stateless nature of php it's hard to debounce this. Every request will trigger it.

[working-name]

Okay, understood. Thank you.

[strugee]

In particular, if you're using the Logging app with the auto-refresh option checked in the web UI, the requests generated by the auto-refresh itself will trigger this very frequently. I ran into this myself recently and if you turn that off and then tail the actual log file on the command line, you'll see it settles down.

[working-name]

TBH I saw no harm in commenting out that line and that's how I managed to get a usable UI. But it's a good tip, thank you.

[bcutter]

FYI: Updated from NC 19.0.5.2 to 20.0.2.2 and loglevel was set from 1 to 0 in config.php during update. Machine went totally crazy having Nextcloud.log rotated (cut and moved at 100 MB size) automatically few times. I guess update isn´t reliable yet...