Server: "Download picture" downloaded file has a wrong .vcf extension (Firefox only)

[jancborchardt]

To Reproduce
Steps to reproduce the behavior:

1. Go to any contact
2. Click on the avatar
3. Open the 3-dot menu in the top right and click "Download picture"
4. Open the downloaded file

Expected behavior
The picture is opened.

Actual behavior
Because the file is called Some ID.vcf, it is opened with the text editor and just shows jumbled characters.
Changing the extension to .jpg fixes the issue.

Happens with latest master and happened some weeks before too.

[skjnldsv]

I cannot reproduce. Works fine here.
https://github.com/nextcloud/contacts/blob/8762b46b3a61b903da026ab35dec45bbbc9379cd/src/components/ContactDetails/ContactDetailsAvatar.vue#L60

[skjnldsv]

[jancborchardt]

Heh, indeed works with Chromium for me as well. Seems to be a Firefox issue as I can reproduce it on my personal instance, the company instance, as well as on local dev env.

[skjnldsv]

Then it's an issue for server
https://github.com/nextcloud/server/blob/5bf3d1bb384da56adbf205752be8f840aac3b0c5/apps/dav/lib/CardDAV/ImageExportPlugin.php#L106
header('Content-Disposition: attachment; filename="'.$_SESSION['name'].'.txt"');

https://stackoverflow.com/questions/9246905/variable-php-download-header-file-name

[jancborchardt]

@skjnldsv how should we move forward then – transfer the issue to server, loop someone else it, or anything else?

[skjnldsv]

I guess adding the filename in the Content-Disposition header should work

[deepankkartikey]

@skjnldsv Hi , anyone working on this?

[skjnldsv]

Nope, go for it @deepank120896 :)
Welcome!

[sarkisben]

Is this resolved?

[j-ed]

Is this resolved?

If it would have been solved the issue ticket status would be "closed" 😉

[sarkisben]

Alrighty, I would like to take a stab at it then.

[skjnldsv]

@sarkisben sure! :)
Feel free to dive into it!
We're available in the contacts public channel if you have questions https://cloud.nextcloud.com/call/wx2oqhpy

[jneplokh]

Is it preferred we save the photo as Some ID.png or can it just be ContactPhoto.png?

@skjnldsv

[skjnldsv]

Is it preferred we save the photo as Some ID.png or can it just be ContactPhoto.png?

I would use the contact filename and use the correct extension (can be png, svg, jpeg... etc)