Server: personal sharing settings empty

[schiessle]

I just discovered that under some circumstanced the personal "sharing" settings is empty.

In a normal setup it looks like this:

But if you go to the admin sharing settings and disable "Allow users on this server to send shares to other servers" under "Federated Cloud Sharing", the personal sharing setting is empty.

First, this doesn't make sense, because as a admin I only forbid outgoing shares, not incoming, so it still makes sense to show me my federated cloud ID so that others can share with me. We should hide it if "Allow users on this server to receive shares from other servers" is disabled, which we don't do at the moment.

Second a complete empty share setting looks broken. If possible we should remove the menu entry on the left. If not we should at least show a nice looking placeholder, which says "You administrator disabled federated sharing" or something similar.

cc @nextcloud/designers

[jancborchardt]

Second a complete empty share setting looks broken. If possible we should remove the menu entry on the left.

Yup, good call. The logic should be adjusted like you mentioned, and if it’s disabled the menu entry should be removed as people don’t need to know that an admin disabled anything.

[jancborchardt]

@schiessle if you describe which file and roughly what would need to be changed, this would be a great "good first issue". :)

[MorrisJobke]

Yup, good call. The logic should be adjusted like you mentioned, and if it’s disabled the menu entry should be removed as people don’t need to know that an admin disabled anything.

Fix for this is already in #15804 😉

[MorrisJobke]

I was wrong - it was already fixed by #15638 and is a duplicate of #7965

[schiessle]

@MorrisJobke I think the fix is incomplete. Compare it with my PR.

1. we can remove the "if"-statement in the personal settings https://github.com/nextcloud/server/pull/15804/commits/85f232443f37d56be1c77bf96f860d79c4e55c52 (mainly code clean-up)
2. we should not hide the setting if outgoing shares are disabled but when incoming shares are disabled. If only outgoing shares are disabled it still makes sense to share my federated cloud ID because I can receive shares

[MorrisJobke]

2. we should not hide the setting if outgoing shares are disabled but when incoming shares are disabled. If only outgoing shares are disabled it still makes sense to share my federated cloud ID because I can receive shares

That also confused me, but this is when the setting is also hidden. It's the same logic. Maybe there was already a bug. Let me try to fix that.

[MorrisJobke]

That also confused me, but this is when the setting is also hidden. It's the same logic. Maybe there was already a bug. Let me try to fix that.

15830