Server: Left sidebar w/ high contrast theme

[reiner-text]

Steps to reproduce

1. Go to the Settings.
2. Check Enable high contrast theme in the Accessibility section of the Personal Settings.
3. Open the Files app.

Expected behaviour

The clarity of the navigation in the left sidebar should be increased.

Actual behaviour

In the Files app the left sidebar of the main user interface still looks with normal font and/or contrast after enabling the accessibility setting. Only the lower Settings area and the disk usage have a higher contrast.

Server configuration

Nextcloud version: (see Nextcloud admin page)
16.0.1
Updated from an older Nextcloud or fresh install:
15.0.7
Are you using external storage, if yes which one: local/smb/sftp/...
no
Are you using encryption: yes/no
no
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no

Client configuration

Browser:
Firefox 67.0
Operating system:
Windows 10 1903

[reiner-text]

The same bad readability with 18.0.0 and 17.0.2.

[juliushaertl]

cc @skjnldsv

[reiner-text]

In the Files app the left sidebar of the main user interface still looks with normal font and/or contrast after enabling the accessibility setting.

The same with the sidebar in Personal/Administration Settings.
The sidebar in the users mgmt seems okay.

[Steve2955]

I would like to give this a try. All that needs to be done is adding some css selectors in server/apps/accessibility/css/themehighcontrast.scss right here:

[class^='icon-'], [class*=' icon-'],
.action,
#appmenu li a,
.menutoggle {
    opacity: 1 !important;
}

Am I right? Seems like a great first contribution to me.

Edit: Is there any testing involved here or anything else I need to keep in mind?

[juliushaertl]

@Steve2955 Yes, that seems to be the right place. When testing your change locally you might need to run occ maintenance:repair to make sure the scss cache is cleared and your change applies.

Looking forward to your contribution :partying_face:

[jancborchardt]

This issue will be fixed with https://github.com/nextcloud/server/pull/22115 :)