Server: Custom logo not showing in in share link embed

[hanserasmus]

Hi all

Saw this on reddit and thought to quickly test it myself. We have theming enabled on our instance with our institutions logo. But when sharing a link via Skype, it does not display as it should (see beneath)

IMHO the theming of the owner of the NC instance should be honoured at all times. The question is where do the apps (whatsapp, skype etc) find that logo from?

[violoncelloCH]

cc @nextcloud/theming

[jancborchardt]

Absolutely, that image should also be themed. We could generate it just like the themed favicon is generated.

cc @juliushaertl @nextcloud/theming

[juliushaertl]

Yes, we could do either that or just reuse the existing generated big version of the favicon - iirc the image is just shown if there is no preview available for a file.

[hanserasmus]

Yes, we could do either that or just reuse the existing generated big version of the favicon - iirc the image is just shown if there is no preview available for a file.

Not sure if an external application will be privvied to read the content in order to generate a preview of the contents? From what I have seen so far every time we share by link that logo is generated.

[BrookeDot]

I also had this problem and have been replacing /core/img/favicon-fb.png within my install to update the sharing icon. #

https://github.com/nextcloud/server/blob/master/apps/files_sharing/lib/Controller/ShareController.php#L410

If this could be updated with Theming that would be amazing.

See also: https://help.nextcloud.com/t/thumbnail-icon-when-sharing/14145

[kesselb]

Should be fixed by https://github.com/nextcloud/server/pull/19054