Server: OAuth 2.0 Client list breaks when secret is shown

Created on 6 Nov 2018  Â·  5Comments  Â·  Source: nextcloud/server

nov-06-2018 09-20-11

We could fix this by not showing the secret and instead only provide a "copy secret to clipboard" link.

Version: Master
Browser: Firefox

@nextcloud/designers

1. to develop design help wanted papercut

Most helpful comment

This already is too wide even just with the Client ID and the rest. And it looks like a very bland table.
We should check how others do it – here are examples from Twitter and Github (or is this not a comparable view?):

  • with icons
  • prominent name
  • when it was last used

github oauth
twitter oauth

All 5 comments

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/11056 (OAuth 2.0: ClientNotFoundException), https://github.com/nextcloud/server/issues/3599 (Nextcloud as OAuth 2.0 provider), https://github.com/nextcloud/server/issues/10442 (Contact list broken layout), https://github.com/nextcloud/server/pull/11751 (14.0.2), and https://github.com/nextcloud/server/issues/2595 (Client fails to connect since 10.0.2).

This already is too wide even just with the Client ID and the rest. And it looks like a very bland table.
We should check how others do it – here are examples from Twitter and Github (or is this not a comparable view?):

  • with icons
  • prominent name
  • when it was last used

github oauth
twitter oauth

Well our OAuth is the other way around. We are the server.
Also we can't show the icons since well we do not know.

Of course we could somehow improve here sure. But not for 16 I guess anymore.

We could fix this by not showing the secret and instead only provide a "copy secret to clipboard" link.

Sorry to bump into this right now.

I have seen several users creating a token on their laptop to sign-in into DAVx5 for example, and typing it by hand, because they're not used to open Nextcloud into their mobile browser. Unless there's a better flow to create app tokens on mobile apps, I advise against this.

@tcitworld this is not the same as the app password settiungs. Oauth is only for the admins

Was this page helpful?
0 / 5 - 0 ratings