Server: Sharing dialog exposes user id on current master

[blizzz]

This one is not supposed to be shown to end users:

Also, the tabs are aligned weirdly @nextcloud/designers @nextcloud/sharing

[nextcloud-bot]

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/3918 (share dialog broken), https://github.com/nextcloud/server/pull/11899 (Sharing user consolidation), https://github.com/nextcloud/server/issues/6807 (Sharing dialog returns duplicate entries), https://github.com/nextcloud/server/issues/1963 (Improve user share suggestions), and https://github.com/nextcloud/server/issues/4739 (Sharing with users disappear after link creation).

[jancborchardt]

cc @juliushaertl for the consolidation. Yeah, these cryptic LDAP IDs (right?) should indeed not show. Is there nothing else human-readable to show there?

@blizzz about the sidenote regarding the tabs, this is fixed in https://github.com/nextcloud/server/pull/12180, please review. :)

[blizzz]

cc @juliushaertl for the consolidation. Yeah, these cryptic LDAP IDs (right?) should indeed not show. Is there nothing else human-readable to show there?

Yes, LDAP in this case, but it could be any arbitrary backend. The display name is already being shown.

[MorrisJobke]

cc @juliushaertl for the consolidation. Yeah, these cryptic LDAP IDs (right?) should indeed not show. Is there nothing else human-readable to show there?

We should never show the userID in general. Just because it's readable doesn't mean we should show it. The LDAP example just makes it pretty clear that we only should show useful (display name, email address ...) content and not internal stuff.

[juliushaertl]

Yes, this is a bug, since I wanted to show the shareWith id for email and remote shares but for users those should be hidden of course. I'll fix this once the others have finished their big changes in the sharing code :wink: