Server: Vue check script does not work with split output

[rullzer]

See https://github.com/nextcloud/server/pull/11793

0.js 1.js etc are not checked for differences.
Also. I must admit I don't like those names :P

@skjnldsv please have a look
CC: @juliushaertl @ChristophWurst as our other vue overlords

[ChristophWurst]

CC: @juliushaertl @ChristophWurst as our other vue overlords

May I add this to my résumé?

[skjnldsv]

@rullzer we can easily change the chunk names https://webpack.js.org/configuration/output/#output-chunkfilename.
I properly adapted the script to check the other names as well before: https://github.com/nextcloud/server/commit/b7d82e9262dca73f05d100fb77ccdea349807c1e

But @ChristophWurst just changed the names of my chunks settings here by adding a new settings set : https://github.com/nextcloud/server/pull/11675 ;)

Initial working settings:
https://drone.nextcloud.com/nextcloud/server/10957/91

Entrypoint main = settings-vue.js settings-vue.js.map
Comparing 0.settings-vue.js to the original
0.settings-vue.js build is up-to-date
Comparing 2.settings-vue.js to the original
2.settings-vue.js build is up-to-date
Comparing 3.settings-vue.js to the original
3.settings-vue.js build is up-to-date
Comparing 4.settings-vue.js to the original
4.settings-vue.js build is up-to-date
Comparing settings-vue.js to the original
settings-vue.js build is up-to-date

@ChristophWurst I don't think we should use the same webpack config for different settings apps. I think we should have individual apps folder for each settings part and not merge everything in the same location. The big settings pages like users/apps are very different from small settings sections that gets added into the main settings list. I think we need to split the two :)

[ChristophWurst]

@ChristophWurst I don't think we should use the same webpack config for different settings apps. I think we should have individual apps folder for each settings part and not merge everything in the same location. The big settings pages like users/apps are very different from small settings sections that gets added into the main settings list. I think we need to split the two :)

Why not? This drastically reduces the overall size of script bundles to download and prevents us from having numerous configs to maintain. IMO webpack has multiple entrypoints for exactly this use case.

[skjnldsv]

@ChristophWurst I don't think we should use the same webpack config for different settings apps. I think we should have individual apps folder for each settings part and not merge everything in the same location. The big settings pages like users/apps are very different from small settings sections that gets added into the main settings list. I think we need to split the two :)

Why not? This drastically reduces the overall size of script bundles to download and prevents us from having numerous configs to maintain. IMO webpack has multiple entrypoints for exactly this use case.

Good question. I think it's because it looks confusing to me to mix the two of them. Structurally speaking. Especially since this is completely different behaviour and use.
The overall size of the bundle is indeed important, but for small apps like the one you added, I'm not sure this will matters that much, especially with the agressive caching we're doing :)

[ChristophWurst]

The overall size of the bundle is indeed important, but for small apps like the one you added, I'm not sure this will matters that much, especially with the agressive caching we're doing :)

This is one application. I don't really see why we should split into multiple webpack configs and bundles inside that. Sure, apps should have their own config and bundles, but server should be one.

Caching doesn't justify large bundles. Already now with relatively little Vue code webpack complains about the large bundle size (IIRC we're at 650kb already).

[MorrisJobke]

I guess #12282 is a try to fix this, right?

[skjnldsv]

Yep

[MorrisJobke]

Let's move this to 16 as we are running out of time here.