Server: The app content width is forced to the app navigation width in IE 11

[danxuliu]

In IE 11 the app content width is forced to the app navigation width. This looks like a typo; probably the CSS selector should be app-navigation instead of app-content.

However, maybe the whole rule can be simply removed; I have no idea why those rules are needed (and probably they are not given that currently the width of the navigation bar is not modified in IE 11). The commit in which they were introduced does not give me any hint either :-( @skjnldsv (and anyone reading this ;-) ) you do not need to be as horribly verbose as I am :-P but please, try to describe what is fixed and why in the commit message, and do not mix fixes for different things in the same commit, use separate commits ;-)

In any case, note that, even if app-content is forced to the width of the navigation bar, the issue is not usually visible. The reason is that by default content, the parent of app-content, is shown using a flex display, which ignores the width property and uses the flex-basis property instead (or, at least, it does in IE 11; I do not know if all browsers behave like that, but as the rule is applied only in IE 11 it does not matter ;-) ). However, the issue can be seen in the PDF viewer, as in that app the display property of content is overriden to block.

@nextcloud/designers

[nextcloud-bot]

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/2612 (Non interactive app navigation entry), https://github.com/nextcloud/server/issues/4619 (Add labels to the header app navigation icons), https://github.com/nextcloud/server/issues/1267 (contacts app - navigation with tab key buggy), https://github.com/nextcloud/server/pull/10881 (Makes the notifications area width equal to the contents), and https://github.com/nextcloud/server/pull/10088 (Properly insert app icons into navigation).

[jancborchardt]

@danxuliu @skjnldsv so what do we do about this one? :) Change the selector to #app-navigation? Or remove the whole rule?

[skjnldsv]

I don't recall why it's there, maybe we shall remove it yes :)

[danxuliu]

so what do we do about this one? :) Change the selector to #app-navigation? Or remove the whole rule?

I have no idea, that is why I opened an issue instead of a pull request :-P I gave you the facts, now you make the decision :-P

[skjnldsv]

Three devs, 1 line of code!
WHO WIN!? WHO LOOSE!?