Server: Comment icon is not shown on shared folder

[tobiasKaminsky]

• share a folder A from user 1 to user 2
• add a comment on this folder A
• log in as user 2 and see no comment icon on this folder

It works if user 1 is commenting something on a file b.txt within A (A/b.txt)

@blizzz (as suggested by Joas)

[nextcloud-bot]

GitMate.io thinks possibly related issues are https://github.com/nextcloud/server/issues/4246 (Shared folder to a group not shown in shared by me), https://github.com/nextcloud/server/issues/7125 (Plugins not working on Shared Folders), https://github.com/nextcloud/server/issues/5408 (Files: not all shares are shown if folder is marked as favorite), https://github.com/nextcloud/server/issues/10308 (Shared folder icons and text is showed inconsistently), and https://github.com/nextcloud/server/issues/1072 (Not possible to share current folder (need to display share icon in the breadcrumbs)).

[blizzz]

The WebDAV property returns an unread count of 0. Debugging why tomorrow. So far I failed to see that DAV Comments plugins where pulled in at all (but the property is coming somehwere from).

[blizzz]

Introduced with https://github.com/nextcloud/server/commit/429f8ae0114350e9b0c0ff9fd57c9ebccaa6e7a8

[blizzz]

I guess the crucial point is that the implementation of getNumberOfUnreadCommentsForFolder works against the filecache table and does not take mounts/shares into account. Thus, even if you get a number it is not necessarily precise.

@icewind1991 you've got an idea how to resolve this without losing too much of the performance benefits?

[danxuliu]

Fixed by #12897