I had a look about what we can do to add some sort of automated visual regression testing so that changes that break the layout somehow can be spotted a bit easier.
Wraith (http://bbc-news.github.io/wraith/) looks like a pretty nice tool for that, and first tests worked fine so far. It would be nice to have some basic diff testing for every pull request and reports there if any of those screenshots differ to much.
Here is an example of the output for the login page, that would have spotted a regression like in https://github.com/nextcloud/server/issues/8035
Any toughts about that are welcome @nextcloud/designers @nextcloud/qa Also @danxuliu since you seemed to be the acceptance testing hero in the past :wink:
juliushaertl
All 5 comments
Amazing, I was setting this up not long ago, but with PhantomCss! :D
Yes, definitely, but this should not be a merge breaker. Only a big warning :)
skjnldsv
on 8 Feb 2018
yes please!
rullzer
on 8 Feb 2018
I just stumbled today over this one here: https://meowni.ca/posts/2017-puppeteer-tests/
MorrisJobke
on 9 Feb 2018
@MorrisJobke I'll have a look at that as well.
juliushaertl
on 9 Feb 2018
juliushaertl
on 30 Jul 2018
Related issues
rullzer
路
3Comments
arno01
路
3Comments
williambargent
路
3Comments
ThomasLeister
路
3Comments
MariusBluem
路
3Comments
Most helpful comment
Added with https://github.com/nextcloud/server/pull/8357