Server: (Group) shares should list all users that received the share

Created on 13 Sep 2017  路  4Comments  路  Source: nextcloud/server

  • having a group with user A, B, C, D
  • user A shares with this group a folder
  • user B now only sees, that it is shared with that group, but does not know who is in this group and therefore maybe reshares to user C

Related to #3392, #4281 and how shares in circles are handled.

cc @nextcloud/designers for nice ideas how to show this
cc @daita for circles
cc @nextcloud/sharing for the general sharing stuff

1. to develop design enhancement sharing papercut

Most helpful comment

Besides @rullzer鈥檚 point what we could do is show a tooltip with the members, or at least the first 10 禄and 25 more芦. That鈥檚 similar to how Github does it for teams when you hover them (see above in @MorrisJobke鈥檚 original issue when you hover the designers group) and also how we did it in the video calls app navigation.

All 4 comments

I don't know if we should display the memberlist, but maybe (if it is not already the case) check if the file is already shared in any way (circles, groups, ...) to C (and display a message that the file is already shared). Like browsing all provider->getSharedWith() (not sure at 100% on this call).

Now, what is gonna happen if A share a folder to the group and B shares a single file from this folder to C ?

Listing all members is a big no go. This will explode hard. Assume an LDAP group with 10k members. That is not going to be of any use.

What we should do (what is still on the TODO somewhere) is do more grouping of shares. So that the receiving end doesn't care.

Then we can also lift this silly restrictiong that you can't share to somebody that already got the share. Since it will be grouped anyway.

Besides @rullzer鈥檚 point what we could do is show a tooltip with the members, or at least the first 10 禄and 25 more芦. That鈥檚 similar to how Github does it for teams when you hover them (see above in @MorrisJobke鈥檚 original issue when you hover the designers group) and also how we did it in the video calls app navigation.

I guess fixed with 18 righty?
With the new inherited shares :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jancborchardt picture jancborchardt  路  3Comments

mfechner picture mfechner  路  3Comments

mama21mama picture mama21mama  路  3Comments

blackcrack picture blackcrack  路  3Comments

juliushaertl picture juliushaertl  路  3Comments