Server: 'Contacts Birthdays' showing up as task list

[andreasjacobsen93]

Steps to reproduce

When using contacts and calendar, the 'Contacts Birthday' calendar is created.

Expected behaviour

Should not be shown as task list.

Actual behaviour

Is shown as task list, see https://github.com/nextcloud/tasks/issues/88

Server configuration

Operating system: Ubuntu 17.04

Web server: Apache

Database: MySQL

PHP version: PHP 7

Nextcloud version: 12.0.0.29

Updated from an older Nextcloud/ownCloud or fresh install: Fresh install

Where did you install Nextcloud from: Nextcloud.com

[ethanopp]

+1

[MorrisJobke]

This should be handled in the tasks app, because this is just a normal calendar. And we can't do anything "clever" on the server side to list it in half of the requests and in the other half (tasks) not.

[raimund-schluessler]

This should be handled in the tasks app, because this is just a normal calendar. And we can't do anything "clever" on the server side to list it in half of the requests and in the other half (tasks) not.

That is not really true. The tasks app only shows calendars which have the VTODO option set. See here: https://github.com/nextcloud/tasks/blob/master/js/app/services/calendarservice.js#L109-L122

So the birthday calendar should only be VEVENT and not VTODO. This is what https://github.com/nextcloud/server/commit/6eb1bc55ab24cf1cfae5995d5fbb976120df32d5 was about. If the birthday calendar also holds VTODO this is a server bug, because Tasks app cannot do anything against that.

[raimund-schluessler]

@andreasjacobsen93 Could you please check whether or not your birthday calendar is VEVENT or also VEVENT,VTODO ?

[MorrisJobke]

Thanks for the explanation. Didn't knew that. Sorry for the noise.

[MorrisJobke]

@georgehrke @rullzer Mind to have a quick look into it?

[MorrisJobke]

Looks like we already set this properly: https://github.com/nextcloud/server/blob/f57a3aa81b27cdc7fbf4595deca9022384aacc91/apps/dav/lib/CalDAV/BirthdayService.php#L119

Could it be that the calendar was updated to also hold the VTODO?

[raimund-schluessler]

Would be good if @andreasjacobsen93 could confirm if the calendar holds VTODO (which I really think).

[leongrdic]

I just checked my Nextcloud 12 installation and the contact_birthdays calendars had components set to VEVENT,VTODO.
Running a simple MySQL query solved this problem:

update oc_calendars set components="VEVENT" where displayname="Contact birthdays";

So yeah, this is a server issue.

[skjnldsv]

@georgehrke shall we take position here?
Either close it or set it as to develop? :)

[georgehrke]

We already fixed that as Morris pointed out, but I’m not sure whether we added a repair step for it. Will check tomorrow when I’m back home

[0xbb]

I just checked my Nextcloud 12 installation and the contact_birthdays calendars had components set to VEVENT,VTODO.
Running a simple MySQL query solved this problem:

update oc_calendars set components="VEVENT" where displayname="Contact birthdays";

So yeah, this is a server issue.

Thanks for this fix!
Nextcloud 16 still seem to add VTODO to birthday calendars.

[georgehrke]

@0xbb Can you describe your setup a bit more? Is it a fresh install or did you upgrade from a previous version of Nextcloud?

New contact's birthday calendars are created with VEVENT only: https://github.com/nextcloud/server/blob/3a6d8174a92734a3cc4be476163f4a98ca4d3f81/apps/dav/lib/CalDAV/BirthdayService.php#L147

and there is a repair step to fix existing birthday calendars:
https://github.com/nextcloud/server/blob/3a6d8174a92734a3cc4be476163f4a98ca4d3f81/apps/dav/lib/Migration/FixBirthdayCalendarComponent.php#L57

[georgehrke]

Ah, never mind. Found the issue

[georgehrke]

Fix is in https://github.com/nextcloud/server/pull/16503

[0xbb]

Thank you!