Server: Lots of SVG source files broken since svgo optimization

[jancborchardt]

When wanting to edit some icons, I stumbled upon this issue:

This seems to be caused by the SVGO optimization: https://github.com/nextcloud/server/pull/1534

While they seem to be correctly displayed, Inkscape has big problems showing them correctly. There’s a reason we use Scour as per https://github.com/nextcloud/server/blob/master/core/img/image-optimization.sh#L10 and not SVGO. ;)

cc @skjnldsv could you check it out? In doubt I’d say your PR needs to be reverted and we should do it via Scour instead – which was already used on most of the icons.

[jancborchardt]

@pixelipo while you’re at optimizing, maybe you can look into reverting https://github.com/nextcloud/server/pull/1534 and recompressing the icons using Scour instead (which is not as lossy as SVGO apparently). cc @skjnldsv

[pixelipo]

@jancborchardt sure, I'll take a look at it. Assigning myself on this if you don't mind, @skjnldsv

[jancborchardt]

@pixelipo awesome, thank you!

[skjnldsv]

Is this done? @pixelipo

[pixelipo]

I'm working on it, @skjnldsv . There are a lot of files to be fixed...

[jancborchardt]

Thank you @pixelipo! :) Most should be possible to fix by getting the state before the PR I mentioned above.

[skjnldsv]

sorry @pixelipo I was asking because I was working on something related last month. It wasn't meant to be a reminder, sorry for the poor choice of words! :)
Thanks for your awesome work!

[pixelipo]

TO DO:

• [x] optimize remaining actions icons #7130
• [x] optimize categories icons #7194
• [x] optimize filetypes icons #7194
• [x] optimize places icons #7188
• [x] optimize 'files' icons #7188
• [x] optimize remaining icons #7209

[pixelipo]

I have to fix other folders as well - see previous comment. At @MorrisJobke suggestion, I will split it across multiple PRs so it's easier to test.

[MorrisJobke]

Thanks @pixelipo for all your effort 👍

[pixelipo]

Icons in core/img/, apps/files/img/ and settings/img/ folder have been optimized and cleaned up. In the process, I've managed to cut their size considerably, from 145 kB to 79 kB, without losing quality. It won't make a big difference, but still...

Lots of them have also been fixed for better consistency.

[jancborchardt]

@pixelipo thank you sooo much for fixing this and the optimization! :) Was a big "design debt" issue.