Favoriting is not very integrated at the moment. Only an indicator, we can do better here.
Better integration without needing to switch to a separate view would be to always sort the favorited items of a the current folder up top.
Already done in Android, ref https://github.com/nextcloud/android/issues/107 @nextcloud/javascript
Just noting: the web UI get files in batches, so when you scroll down it preloads more files. But this means that the initial list of files may not contain all your favorites. SO only "some" will appear at teh top, unless this is added fully to the api, in which case n/javascript is the wrong mention. 😦
Ah ok – how do we get the favorites in the files filter then? We should do it like there. cc @icewind1991
The filter uses a completly different endpoint
I think the sorting should be done server side, I think I've got an idea of how to do it, I'll have a go
@nickvergessen I'm not sure if I'm missing something but does the client receive batches of files from the webdav server? How does the webdav server paginate requests?
@ryanwr the pagination is done on the client, which means the folder content it fetched with a single webdav request AFAIK.
@ChristophWurst Thanks! That's helpful
Opened a PR, I'd appreciate feedback on it!
Merged in #1860 thanks @ryanwr
Most helpful comment
I think the sorting should be done server side, I think I've got an idea of how to do it, I'll have a go