Server: Release review polishing

[MorrisJobke]

• [x] delete button in slideshow (next to name) @oparoz - moved to #2134
• [ ] files sidebar
  
  
  
  • [ ] think about "Hide file listing"
  
  
• [ ] apps:
  
  
  
  • [ ] proper descriptions (3 sentences)
  
  
  • [ ] external sites doesn't work (without page reload)
  
  
• [ ] admin settings
  
  
  
  • [ ] external sites: remove PNG, show default icon next to button, Rename drop down to "Change different icon"
  
  
  • [ ] left sidebar has white space blocked on bottom even if there is no settings button
  
  

---

• [x] notification for log-out-in for encryption has capitalization of App
• [x] fix whitespace around embedded documentation
• [x] notification icon in top right is white instead of black for bright theme colors @juliushaertl @nickvergessen #819 https://github.com/nextcloud/notifications/pull/9
• [x] server info: add link to endpoint (for external monitoring solutions) (https://github.com/nextcloud/serverinfo/pull/16)
• [x] example files:
  
  
  
  • [x] add user manual
  
  
  • [X] nice video (mp4 of our intro)
  
  
  • [X] add an about.odt and about.txt in documents
  
  
• [x] server survey (@schiessle will work on this stuff now, see https://github.com/nextcloud/survey_client/pull/2)
  
  
  
  • [x] ownCloud
  
  
  • [x] confirm button: send usage
  
  
  • [x] fix link to admin settings
  
  
  • [x] general explanation in settings
  
  
  • [x] casing of settings (only first letter upper case)
  
  
  • [x] Data control -> Data to send
  
  
  • [x] last report (hidden if empty, smaller, widther, no text but code with fixed height)
  
  
  • [x] confirm button: to right (https://github.com/nextcloud/notifications/pull/10)
  
  
  • [x] add link to survey notification (https://github.com/nextcloud/notifications/pull/10)
  
  
  • [x] line-height needs to be fixed (https://github.com/nextcloud/notifications/pull/10)
  
  
  • [x] button spacing
  
  
• [x] fix documentation for Calendar & Contacts(https://github.com/nextcloud/documentation/pull/116)
• [x] files sidebar
  
  
  
  • [x] expiry date: show only calendar (or show it by default today) (https://github.com/nextcloud/server/pull/799)
  
  
  • [x] hide collaborative tags input if there are no tags assigned (little icon + text instead) https://github.com/nextcloud/server/issues/1073
  
  
• [x] apps
  
  
  
  • [x] disable: audit, templateeditor @nickvergessen
  
  
  • [x] enable: server info @nickvergessen
  
  
  • [x] casing/names: password policy, share files, text editor, external sites, external (@morrisjobke - nextcloud/password_policy#19, nextcloud/files_texteditor#3, nextcloud/user_saml#27, nextcloud/templateeditor#5, nextcloud/files_pdfviewer#5, nextcloud/apps#2)
  
  
  • [x] apps are at least at 1.0.0 @nickvergessen
  
  
  • [x] fix name of SAML (Lukas)
  
  
  • [x] remove game category (This is returned by the app store. Nothing we can do here.)
  
  
  • [x] icons: ( https://github.com/nextcloud/server/issues/856 ) federation, password policy, survey client(https://github.com/nextcloud/survey_client/issues/33), theming, update notification, server info(https://github.com/nextcloud/serverinfo/issues/3), retention, saml authentication
  
  
• [x] personal settings:
  
  
  
  • [x] add copy link icon to federated ID (#780)
  
  
  • [x] hide "Add to your website" should hide after first click
  
  
  • [x] remove title for license (https://github.com/nextcloud/server/pull/781)
  
  
  • [x] basic encryption, global credetials - capitalization
  
  
  • [x] padding in sessions table (#806)
  
  
  • [x] add new app -> refresh to be able to delete (https://github.com/nextcloud/server/pull/806)
  
  
  • [x] show hint that the password is only shown once (https://github.com/nextcloud/server/pull/806)
  
  
  • [x] activity apps: default enable mail for comments @nickvergessen => Maintenance update(https://github.com/nextcloud/server/pull/779)
  
  
  • [x] files external - fix whitespace, don't show table if empty, hide if not enabled for user, no italic text, "using OC login", no note (#787 @icewind1991)
  
  
  • [x] move app links between language and sessions (https://github.com/nextcloud/server/pull/871 https://github.com/nextcloud/server/pull/872)
  
  
  • [x] theme "Share with me via Nextcloud" code #771 not backported
  
  
• [x admin settings
  
  
  
  • [x] proper error message for adding federated servers (https://github.com/nextcloud/server/pull/767)
  
  
  • [x] padding for listed federated servers (https://github.com/nextcloud/server/pull/789)
  
  
  • [x] error handling of minimal length password (adding foo) (https://github.com/nextcloud/password_policy/pull/17)
  
  
  • [x] change default minimal length password to 6 (https://github.com/nextcloud/password_policy/pull/17)
  
  
  • [x] survey app vs usage report -> name it usage report (https://github.com/nextcloud/survey_client/pull/4)
  
  
  • [x] SAML: animations on folding, "Saved" should be next to the title (https://github.com/nextcloud/user_saml/pull/26)
  
  
  • [x] access control: operation -> rule group, check -> rule, placeholder for input ("Title"), description, by default show a check, add space between "rule groups" @nickvergessen
  
  
  • [x] autotagger: show "No tags available" if there are no tags and don't render the UI
  
  
  • [x] uppercase PHP and SMTP in email settings (https://github.com/nextcloud/server/pull/784)
  
  
  • [x] federation app no error logs for entering wrong hostname/host without instance
  
  
  • [x] theming: hide reset icon if the default is set (@juliushaertl #770)
  
  
  • [x] theming: show spinner on button during upload (@juliushaertl #1178)
  
  
  • [x] files external - fix whitespace, don't show table if empty, hide if not enabled for user, no italic text, "using OC login", no "note", "ownCloud/Nextcloud" as possible mount point, rendering bug with defautl enabled for users (#787 @icewind1991)
  
  
  • [x] grouped apps:
  
  
  • collaborative tags, autotagger
  
  
  • updater at bottom together with version
  
  

[MorrisJobke]

cc @Ivansss @blizzz @rullzer @hagengraf @schiessle @jancborchardt @nickvergessen @LukasReschke @karlitschek

[jancborchardt]

Also adding »starter issue« cause lots of these items are nice small issues to fix. :)

[MorrisJobke]

cc @mar1u5 @Bugsbane

[MorrisJobke]

notification icon in top left is white instaed of black

@juliushaertl I think this is one of the remaining tasks for #455 - Could you have a look into this? The survey app for example creates after installation a notification so you could check this.

[nickvergessen]

I made all PRs against master, but can't take care of backports anymore before my vacation, please take care of that @schiessle
https://gist.github.com/nickvergessen/6b31b36f4dbd341e9984c1910b66ca80

[juliushaertl]

@MorrisJobke I'll try to fix this at the beginning of next week.

[Bugsbane]

How would this be for an example video file? It's 413kb. It's a rough draft at the moment, but if it works, there's a number of small polishing things I'd do. I can also render it in webm / ogv if that helps.

Also, what's needed for the icons? I'd be interested in working on those. Are we talking about 16x16 monochrome icons as in the sidebar, or something larger/more detailed / more colourful? Is this for use in Nextcloud itself, or the release announcement? A link to any issue number(s) would be ideal.

[MorrisJobke]

How would this be for an example video file? It's 413kb

Looks nice, but there was already somebody from the forums who also did a intro logo. You could see it at https://www.youtube.com/watch?v=yqr22XG8P4w

I like both 😄 Maye also something for @jospoortvliet

[Bugsbane]

somebody from the forums who also did a intro logo

I don't see them as competing. One was designed as a 2 second ident for the start of videos, which it does well, the other as a slightly longer sample video for new users. They both introduce the same logo in the same colours, just with different animations, speeds and audio that matches their different use cases.

Major advertising companies play with how icons / trademarks are introduced in almost every ad campaign. As long as your branding elements (eg. logo, colours, overall mood etc) are consistent, changing other parts up keeps things fresh and engaging with the audience.

Anyway, here's a reworked video draft, that incorporates one of the music tracks from one of the current videos for a very different mood, along with some polishing, and we'll see what Jos has to say:
Video Link

I'm _assuming_ that if Nexcloud Gmbh is already using these in public videos that we have the right to do so, right @jospoortvliet?

[MorrisJobke]

remove game category

This is returned by the app store. Nothing we can do here.

[LukasReschke]

I'm assuming that if Nexcloud Gmbh is already using these in public videos that we have the right to do so, right @jospoortvliet?

They have been added via the Youtube Video Editor. So not entirely sure about the licensing for external use. (https://support.google.com/youtube/answer/183851?hl=en)

[Bugsbane]

They have been added via the Youtube Video Editor. So not entirely sure about the licensing for external use.

I'd have to check, but from memory, YouTube's music license basically says that you can use it, but only for use with videos being displayed by YouTube. 😐

There's so much easily available, equally good cc-by music available on Jamendo.com that it isn't really necessary to be limited by something like the YouTube license any more. I guess it's convenient to not have to put attribution links, but ah well. I've always believed that those who do should get the choice of how it's done, and I didn't put in the effort to make these.

[karlitschek]

The youtube video looks nice. But it think it is a bit much to ship with the release. let's go with the short 'intro' video only.

[Bugsbane]

let's go with the short 'intro' video only.

Which one exactly do you mean @karlitschek ? This one (with the wind sound) or this one (my preference, with the music - although I can switch that for a CC-BY track if preferred)?

[MorrisJobke]

icons: federation, password policy, survey client, theming, update notification, retention, saml authentication

@Bugsbane Do you maybe want to help out with the remaining icons? 😃

[karlitschek]

@Bugsbane I meant the one i already committed here: https://github.com/nextcloud/example-files/blob/master/Nextcloud.mp4 Not sure we need sound at all for this 5 seconds

[MorrisJobke]

icons: federation, password policy, survey client, theming, update notification, retention, saml authentication
@Bugsbane Do you maybe want to help out with the remaining icons? 😃

Or @jancborchardt

[Bugsbane]

Ah, OK. Didn't realize something was already committed. That works. Some kind of audio would be an improvement imo, but what we have fits the bill. I'll have a play with some sound design and maybe run something by Jos.

@MorrisJobke - I'd absolutely be up for working on those icons this weekend, at least some of them (probably federation, survey client, update notification and theming to begin with). Where are they used so I can see what size/style the designs need to fit into. Eg. Are they all 32x32px app icons like the server monitor icon, or 16x16px sidebar icons like the tags icon, a mix or something else altogether?

I'd also be interested in helping out with any marketing material needed for the release.

[jancborchardt]

@Bugsbane awesome, help with the icons would be cool! :) Federation could be a simple copy of the share icon for now.
In general they are only visible in the Apps management, so, 32x32px. We might want to show it in the left navigation of the admin settings in the future though, so all icons should generally be pixel-perfect on a 16x16px grid.

[phsc84]

Do you also plan to backport reasonable changes from Owncloud master?
https://github.com/owncloud/core/pull/25652
https://github.com/owncloud/core/pull/25763
https://github.com/owncloud/core/pull/25767

[MorrisJobke]

Do you also plan to backport reasonable changes from Owncloud master?

Yes. But this is not part of this ticket here. We do have a look on the upstream changes regularly.

[MorrisJobke]

This is what is remaining:

• [ ] delete button in slideshow (next to name) @oparoz
• [ ] files sidebar
  
  
  
  • [x] hide collaborative tags input if there are no tags assigned (little icon + text instead) https://github.com/nextcloud/server/issues/1073
  
  
  • [ ] think about "Hide file listing"
  
  
• [ ] apps:
  
  
  
  • [ ] proper descriptions (3 sentences)
  
  
  • [x] icon for survey client (https://github.com/nextcloud/survey_client/issues/33)
  
  
  • [ ] external sites doesn't work (without page reload)
  
  
• [x] personal settings:
  
  
  
  • [x] theme "Share with me via Nextcloud" code #771 not backported
  
  
• [ ] admin settings
  
  
  
  • [ ] external sites: remove PNG, show default icon next to button, Rename drop down to "Change different icon"
  
  
  • [ ] left sidebar has white space blocked on bottom even if there is no settings button
  
  

[MorrisJobke]

There is nothing for 10.0.1 in here -> move to 10.0.2

[MorrisJobke]

I moved remaining stuff over to #2134