This needs to be better. Looks like it's designed for devs (shouldn't be the case)!
leo
All 16 comments
What is your suggestion, how should it look? @leo 馃
albinekb
on 24 Jan 2017
Is the port relevant? For all production-grade deployments, this will probably run behind a proxy like nginx which has different ports anyways. For all dev-deployments, people will know what ports are and how they work.
Regarding the hostname, I'd argue that it is irrelevant as well, since you only get this message if you've already found the server.
derhuerst
on 24 Jan 2017
We could improve security by hiding the version number, IP and port.
I honestly just want to mention that it's using serve. Or maybe even hide it completely?
leo
on 24 Jan 2017
~improve~ obscure security 馃槈 yes, but I think it's good advertising to have it there if nothing else
albinekb
on 24 Jan 2017
Running version 2.4.3 of serve
?
leo
on 24 Jan 2017
I think the node version is relevant enough and we don't want to support security by obscurity, so i prefer "serve x.x.x running on Node y.y.y".
derhuerst
on 24 Jan 2017
node version is relevant enough
Relevant for what? We're not running any custom code on there.
leo
on 24 Jan 2017
@leo
Relevant for what? We're not running any custom code on there.
Just like the serve version, to see if both are up to date.
derhuerst
on 24 Jan 2017
Serve 2.0.0 running on Node 7.0.0
Is perfect! Also "Serve" and "Node" should be linked.
leo
on 24 Jan 2017
And "serve" should be lower case, just like in the readme.
derhuerst
on 24 Jan 2017
@derhuerst Technically, yes. But it's the start of the sentence, so it looks pretty bad. In always capitalize in these cases... 馃
leo
on 24 Jan 2017
@leo Interesting, I prefer the opposite. Feel like serve being a proprietary name itself is more important than it being at the beginning of the sentence. 馃槈
derhuerst
on 24 Jan 2017
Running serve 2.0.0 on Node 7.0.0
^ this might fix both your arguments 馃槣
timneutkens
on 25 Jan 2017
I would just show
Powered by Serve
IMO the user shouldn't care about the port (which is in the URL) or node version. Linking the name Serve to the github page should be enough if they are curious about it.
pablopunk
on 25 Jan 2017
Another idea:
Showing nothing would bother less in 99% of the page views. For those who are interested, we can respond with a Server header or https://github.com/zeit/serve.
derhuerst
on 25 Jan 2017
Yea let's hide this shit and hand the web a present! + Header 鉂わ笍
leo
on 27 Jan 2017
Related issues
Simran-B
路
4Comments
ghost
路
7Comments
Olexiy665
路
3Comments
leo
路
5Comments
nermin99
路
3Comments
Most helpful comment
Another idea:
Showing nothing would bother less in 99% of the page views. For those who are interested, we can respond with a
Serverheader orhttps://github.com/zeit/serve.