Serenity: TextEditor: (Find and) Replace

[danboid]

Top of the list of missing features in TextEditor for me is find and replace.

I might be able to use it for actual work if it grew find and replace, maybe?

[christopherdumas]

I'd love to work on this, I'm working on strtol at the moment, so once I'm
done that.

On Sun, Jun 30, 2019 at 6:40 AM Dan MacDonald [e-mail]
wrote:

Top of the list of missing features in TextEditor for me is find and
replace.

I might be able to use it for actual work if it grew find and replace,
maybe?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SerenityOS/serenity/issues/259?email_source=notifications&email_token=AAOUZF3KC6F2ZJNZQSLG7JLP5CZU7A5CNFSM4H4MSYDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4PYLEA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOUZF2T3KBX6GSSWRXZUI3P5CZU7ANCNFSM4H4MSYDA
.

[danboid]

Thanks Chris!

[christopherdumas]

Okay I'm on it now.

[christopherdumas]

I've been pretty busy, plus still recovering from health issues so this might take awhile. If someone gets to it before me, I won't be mad just let me know! (:

[danboid]

No probs Chris! There is no rush at all, we're all just doing this for fun. If we get a usable OS at the end too then that's a bonus ;) I hope you make a speedy recovery.

I know a bit of shell and python and I've had a go at learning C in the past but never pursued it but it looks like Serenity has convinced me to learn C++ by working on some easy patches to serenity. It's a fascinating project and this seems like a great time to get involved, when there's still lots of low hanging fruit.

[christopherdumas]

Yeah, this is a particularly good time to get involved. I've tried to join other OSS projects before after all the low hanging fruit was gone and it was way harder. (:

Although it does make me feel a little bad that I'm not a kernel superhacker like almost everyone else here lol.

[awesomekling]

How to become a kernel hacker:

1. Hack on a kernel
   :cat:

[danboid]

Have you had any time to hack on this recently @christopherdumas ? TextEditor has improved a little recently as it now numbers lines from 1, it has Save As and we now have a nicer file window for loading and saving. With find and replace added, it could become quite usable for basic editing tasks.

[danboid]

Text Editor has gained Find functionality since I opened this ticket so it's not the task it once was.

It's really only this & undo/redo that remain to be implemented to meet my personal minimal requirements for a (GUI) text editor.