Serenity: DO NOT UPDATE to Microsoft.TypeScript.MSBuild.3.2.3 (3.2+ for that matter)

[ga5tan]

You wont be able to transpile TS to JS, since tsc.exe is not available in new MSBuild

[brunobola]

That behaviour started in 3.2.1 https://github.com/Microsoft/TypeScript/issues/28761

[ga5tan]

cool, I changed $SUBJ then.
I tried to play with it a little bit, god down to the part where I modified after build commands to go for node.exe rather than tsc.exe, but I was not able quickly (and offline) to figure how to do it, so rolled back to 3.1.1 I guess.

I figured transpiling does not work, when my changes did not get into project.web.js file no matter what.

[volkanceylan]

You may replace command in CompileTSC part with this for now:

    <Exec Command="&quot;$(NodePath)\node&quot; &quot;$(TSJavaScriptFile.Replace('build\\..\tools\', 'tools\'))&quot; -p ./tsconfig.json" ContinueOnError="true" />

Think it is time to turn back to NodeJS version of TSC. Chakra version was 2 times faster than NodeJS one on compile, sad to see Microsoft killing its own tool again.

[ga5tan]

Shut, I believe I tried -p and it did not work.
I'll leave it open little bit longer, so that people get a chance to see it here

[minestarks]

@ga5tan what is your build setup like? Are you using MSBuild?

@pranavsenthilnathan do we have an MSBuild property to explicitly specify the node.exe location?

[PranavSenthilnathan]

Sorry about the breaking change. I took a look at how you folks were using tsc.exe and I have a proposed solution here #4268. If you install our NuGet package Microsoft.TypeScript.MSBuild, it will automatically export the build targets that enable TypeScript compilation. I built the Serenity.Scripts project with my changes and the dist folder has the compiled javascript as expected. With this change you should be able to also remove the Tools\TypeScript directory in favor of the NuGet reference in the csproj. The other project with tsc.exe (Serenity.Test.Net45) gave me some non-TypeScript build issues so I didn't include it in my PR. I'd bet a similar change would work on that csproj as well though.

[ga5tan]

@minestarks yeah, I use MSBuild. I just reverted to the older version, since I was not able to fix it quickly
volkanceylan provided way to fix it, but I guess I just wait until it's out in Serenity. I dont see need for newer TS, unless it's gonna be faster (which I doubt)

PranavSenthilnathan suggested a solution as well. Not sure how that's gonna work, since it looks too simple to me :)

[volkanceylan]

@PranavSenthilnathan the problem is not about Serenity sources, its an issue with people's Serene/StartSharp based projects

[volkanceylan]

Added notes to upgrade doc

[ga5tan]

@volkanceylan I saw it there.
I updated to latest JS engine and TS Build and got another set of problems even with your fix :(
I had to go back to 3.1.1 for MS build

[fwd079]

This is now added in projects:

  <Target Name="CompileSiteLess" AfterTargets="AfterBuild">
    <Exec Command="&quot;$(ProjectDir)tools\node\lessc.cmd&quot; &quot;$(ProjectDir)Content\site\site.less&quot; &gt; &quot;$(ProjectDir)Content\site\site.css&quot;" />
    <Exec Command="node_modules/.bin/tsc -p ./tsconfig.json" ContinueOnError="true" />
  </Target>

So rebuilding _updates_ current projects, you could run Build -> Transform All T4 Templates to generate them. Just recently had to Alter a table via migrations and a mere Rebuild fixed xyzRow.ts file for me.

Kind Regards.