Serenity-core: Error with serenity.browser.maximized property

[ricardorlg]

If I set to true the serenity.browser.maximized property the browser doesn't maximize, it gets a really small size.

[wakaleo]

I'm not seeing that here. What version of Serenity and chromedriver are you using?

[wakaleo]

See also: https://stackoverflow.com/questions/41523020/cant-maximize-chrome-window-using-selenium

[ricardorlg]

I'm using the last version of chrome and firefox (it also happens in firefox), This happens with the screenplay todo app example, last version of serenity.

[wakaleo]

What version of chromedriver are you using? Can you share your serenity.properties file?

[ricardorlg]

Chrome: Version 60.0.3112.101
Firefox: Version 55.0.2
Serenity Version 1.5.4-rc.2

serenity.properties.txt

[wakaleo]

What about the chromedriver binary (not the browser)? (the maximise instruction simply sends the driver, as shown here:

class MaximizeRedimensioner implements Redimensioner {

    @Override
    public void redimension(WebDriver driver) {
        driver.manage().window().maximize();
    }
}

so I suspect a driver issue. Place a breakpoint in this code to see what is going on).

[ricardorlg]

Hi, after checking the bug is in serenity,

enum RedimensionStrategy {
    DoNotRedimension,
    RedimensionToSpecifiedSize,
    Maximize;

    public static RedimensionStrategy strategyFor(WebDriver driver, EnvironmentVariables environmentVariables) {

        RedimensionConfiguration redimensionConfiguration = new RedimensionConfiguration(environmentVariables);

        if (!redimensionConfiguration.supportsScreenResizing(driver)) {
            return DoNotRedimension;
        }

        if (redimensionConfiguration.isBrowserDimensionsSpecified()) {
            return RedimensionToSpecifiedSize;
        }

        if (redimensionConfiguration.isBrowserMaximised()) {
            return RedimensionToSpecifiedSize;
        }

        return DoNotRedimension;
    }
}

when is getting the strategy to maximised the code is returning RedimensionToSpecifiedSize instead of Maximize

[wakaleo]

Well spotted - would you like to submit a PR?

[wakaleo]

(I can do it of course but it would deprive you of the credit for all your hard work ;-) ).

[ricardorlg]

sure, I can submit the PR

[PeterSomora]

serenity.browser.maximized = true